Fix/sentinel endpoint improvements #27
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…esponse-code-on-empty-incident
…nel-endpoint-improvements
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
There was a problem hiding this comment.
Pull Request Overview
This PR improves the Sentinel ingest endpoint by refactoring the endpoint logic, adding additional tests for various incident and alert scenarios, and fixing mypy errors related to status mapping.
- Refactored ingest endpoint with clearer error handling and logging
- Added more extensive tests covering incident updates and alert-less incidents
- Updated mapping logic for Sentinel incidents and XDR alerts to align with current requirements
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| plugins/sentinel/test/unit/test_ingest.py | Added tests for incident ingestion and status updates |
| plugins/sentinel/test/unit/sentinel.json | Updated sample JSON data and status values for consistent mapping |
| plugins/sentinel/sentinel/routes/ingest.py | Refactored endpoint logic with improved exception handling and logging |
| plugins/sentinel/sentinel/mapping/xdr_alert.py | Changed alert mapping from a dossier structure to a simplified data field |
| plugins/sentinel/sentinel/mapping/sentinel_incident.py | Updated mapping and docstrings for consistent naming and status handling |
Comments suppressed due to low confidence (1)
plugins/sentinel/sentinel/mapping/xdr_alert.py:235
- The mapping now packages the entire graph_alert as a JSON string under 'data' instead of the previous 'dossier' structure; confirm that downstream systems can handle this change.
"data": [json.dumps(graph_alert)],
cccs-mdr
approved these changes
Jun 10, 2025
Co-authored-by: Matthew Rafuse <[email protected]>
Co-authored-by: Matthew Rafuse <[email protected]>
Co-authored-by: Matthew Rafuse <[email protected]>
Co-authored-by: Matthew Rafuse <[email protected]>
cccs-nicefield
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactored ingest endpoint
Added tests for a few different scenarios
Fixed mypy error in mapping of status