Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in logrotate mounting #4145

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Fix bug in logrotate mounting #4145

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2eb7e67
Fix bug in logrotate mounting
benjaminjb Mar 24, 2025
054dbff
Change logic to includeLogrotate
benjaminjb Mar 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/collector/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,6 +54,11 @@ func AddToPod(
return
}

// We only want to include log rotation if this type of pod requires it
// (indicate by the includeLogrotate boolean) AND if logging is enabled
// for this PostgresCluster/PGAdmin
includeLogrotate = includeLogrotate && OpenTelemetryLogsEnabled(ctx, spec)

// Create volume and volume mount for otel collector config
configVolumeMount := corev1.VolumeMount{
Name: "collector-config",
Expand Down