Add Form Controls Layout support for Radio Group #624
Conversation
🦋 Changeset detectedLatest commit: 13fc1c8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| font-family: var(--glide-core-heading-xxxs-font-family); | ||
| font-size: var(--glide-core-heading-xxxs-font-size); | ||
| font-style: var(--glide-core-heading-xxxs-font-style); | ||
| font-variant: var(--glide-core-heading-xxxs-font-variant); | ||
| font-weight: var(--glide-core-heading-xxxs-font-weight); | ||
| line-height: 1; |
There was a problem hiding this comment.
Moved to Radio Group Radio above. No other element needs it.
| @@ -4,13 +4,11 @@ export default [ | |||
| css` | |||
| .component { | |||
| color: var(--glide-core-text-body-1); | |||
| display: inline-flex; | |||
There was a problem hiding this comment.
Unnecessary as far as I can tell. It was also adding extra whitespace above Radio Group. Barely noticeable in the screenshot.
Before
After
There was a problem hiding this comment.
Yup that's exactly what I was seeing as well.
| @@ -7,7 +7,6 @@ export default [ | |||
| `, | |||
| css` | |||
| :host { | |||
| display: flex; | |||
There was a problem hiding this comment.
Apparently unused.
clintcs
force-pushed
the
add-form-controls-layout-support-to-radio-group
branch
3 times, most recently
from
8ec689b to
122a7ce
Compare
clintcs
requested review from
danwenzel,
dylankcrwd and
ynotdraw
as code owners
clintcs
force-pushed
the
add-form-controls-layout-support-to-radio-group
branch
from
122a7ce to
b0e911f
Compare
| @@ -4,13 +4,11 @@ export default [ | |||
| css` | |||
| .component { | |||
| color: var(--glide-core-text-body-1); | |||
| display: inline-flex; | |||
There was a problem hiding this comment.
Yup that's exactly what I was seeing as well.
|
Pushed an amended commit to resolve the conflicts from #615. |
clintcs
force-pushed
the
add-form-controls-layout-support-to-radio-group
branch
from
b0e911f to
13fc1c8
Compare
🚀 Description
N/A
📋 Checklist
🔬 How to Test
Just a quick spot check of Radio Group outside of Form Controls Layout should do.
📸 Images/Videos of Functionality