Add values to Checkbox Group's value in order of selection
#577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ad80886 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
clintcs
force-pushed
the
checkbox-group-value-order
branch
2 times, most recently
from
fac88c5 to
df0a1a1
Compare
clintcs
force-pushed
the
checkbox-group-value-order
branch
from
df0a1a1 to
552311b
Compare
clintcs
requested review from
danwenzel,
dylankcrwd and
ynotdraw
as code owners
danwenzel
reviewed
Jan 3, 2025
src/checkbox-group.ts
Outdated
| this.value = this.value.filter((value) => { | ||
| return ( | ||
| // No idea why TypeScript thinks `event.target` is possibly `null` | ||
| // when filtering given it's narrowed out above. |
There was a problem hiding this comment.
I think you may be running into https://stackoverflow.com/a/79173023
There was a problem hiding this comment.
Aha. I might just delete the comment. Any objections?
danwenzel
approved these changes
Jan 3, 2025
ynotdraw
approved these changes
Jan 3, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Description
A minor detail to match Dropdown and because consumers likely expect us not to mess with the order of the values.
📋 Checklist
🔬 How to Test
valueattribute is["two", "three", "one"].valueattribute is["two", "one"].valueattribute is["two", "one", "three"].📸 Images/Videos of Functionality
N/A