Skip to content

Allow Dropdown to close when something other than its button is clicked #444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2024

Conversation

clintcs
Copy link
Collaborator

@clintcs clintcs commented Oct 25, 2024

🚀 Description

Dropdown now opens and closes when any part of it is clicked. Previously, it would only close with a click outside of itself or one on the button with the caret icon.

📋 Checklist

🔬 How to Test

  1. Navigate to Dropdown in Storybook.
  2. Click the padding around Dropdown.
  3. Verify Dropdown is open.
  4. Click the padding again.
  5. Verify Dropdown is closed.
  6. Make Dropdown multiselect.
  7. Select an option.
  8. Click the option's tag.
  9. Verify Dropdown is closed.
  10. Click the tag again.
  11. Verify Dropdown is open.
  12. Make Dropdown filterable.
  13. Click the input field.
  14. Verify Dropdown is open.
  15. Click the input field again.
  16. Verify Dropdown is closed.

📸 Images/Videos of Functionality

N/A

Copy link

changeset-bot bot commented Oct 25, 2024

🦋 Changeset detected

Latest commit: 6a5f338

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@clintcs clintcs force-pushed the liberalize-how-dropdown-can-be-closed branch 2 times, most recently from 03c91b9 to 0e2cb53 Compare October 25, 2024 19:56
@clintcs clintcs force-pushed the liberalize-how-dropdown-can-be-closed branch from 0e2cb53 to 6a5f338 Compare October 25, 2024 20:00
@clintcs clintcs marked this pull request as ready for review October 25, 2024 20:00
@clintcs clintcs merged commit b6d24ce into main Oct 28, 2024
7 checks passed
@clintcs clintcs deleted the liberalize-how-dropdown-can-be-closed branch October 28, 2024 19:26
@github-actions github-actions bot mentioned this pull request Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants