-
Notifications
You must be signed in to change notification settings - Fork 3
Add tree component #39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: e545b69 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
6626a49
to
0a91f81
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent work, Dan! It's cool to see this come together.
One question: it looks like a Menu component within a tree item is not accessible with the keyboard only. Any thoughts or ideas on how we may go about supporting that? We can file a follow up task if tackling that seems really difficult at the moment, as I'm not sure we need the nested-menus right away.
A couple of quick thoughts before merging:
- Probably want Mary and Joe to review the UI/UX
- Should add a changeset so it gets picked up in the release notes. Can do so by running
pnpm changeset
bacb925
to
0074229
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Last thing - before merging, don't forget a changeset
with pnpm changeset
!
bb50ce3
to
cd3ea17
Compare
e0a8f07
to
5ed1dc8
Compare
This reverts commit cd3ea17.
We'll build it in a separate PR
5ed1dc8
to
fd949ac
Compare
@clintcs @ynotdraw @dylankcrwd - Per discussion with Tony, I went ahead and removed the 3-dot menu for now, as I've run into challenges with architecting it the right way. We'll split that into a separate PR Other than that, I think I've covered all review comments, if you'd like to take one more look before merging |
@danwenzel: Looks good to me! |
Yup, |
Adds
Tree
andTreeItem
components.https://glide-core.crowdstrike-ux.workers.dev/add-tree-component?path=/docs/tree--overview
These components follow the ARIA authoring pattern for trees.
🚀 Description
📋 Checklist
🔬 How to Test
📸 Images/Videos of Functionality