Skip to content

Add tree component #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 20 commits into from
Apr 26, 2024
Merged

Add tree component #39

merged 20 commits into from
Apr 26, 2024

Conversation

danwenzel
Copy link
Collaborator

@danwenzel danwenzel commented Apr 15, 2024

Adds Tree and TreeItem components.

https://glide-core.crowdstrike-ux.workers.dev/add-tree-component?path=/docs/tree--overview

These components follow the ARIA authoring pattern for trees.

🚀 Description

📋 Checklist

  • I have read and followed the Contributing Guidelines.
  • I have added tests to cover new or updated functionality.
  • I have created or updated stories in Storybook to document the new functionality.
  • I have included a changeset with this Pull Request if it adds/updates/removes functionality for consumers.
  • I have scheduled a Design Review for these changes, if one is required.
  • I have followed the ARIA Authoring Practices Guide and/or met with the Accessibility Team to ensure this functionality is accessible.

🔬 How to Test

📸 Images/Videos of Functionality

Copy link

changeset-bot bot commented Apr 15, 2024

🦋 Changeset detected

Latest commit: e545b69

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@crowdstrike/glide-core-components Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

@danwenzel danwenzel force-pushed the add-tree-component branch 7 times, most recently from 6626a49 to 0a91f81 Compare April 17, 2024 16:48
@danwenzel danwenzel marked this pull request as ready for review April 17, 2024 16:53
Copy link
Collaborator

@ynotdraw ynotdraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work, Dan! It's cool to see this come together.


One question: it looks like a Menu component within a tree item is not accessible with the keyboard only. Any thoughts or ideas on how we may go about supporting that? We can file a follow up task if tackling that seems really difficult at the moment, as I'm not sure we need the nested-menus right away.


A couple of quick thoughts before merging:

  • Probably want Mary and Joe to review the UI/UX
  • Should add a changeset so it gets picked up in the release notes. Can do so by running pnpm changeset

@danwenzel danwenzel force-pushed the add-tree-component branch 2 times, most recently from bacb925 to 0074229 Compare April 23, 2024 17:46
Copy link
Collaborator

@ynotdraw ynotdraw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last thing - before merging, don't forget a changeset with pnpm changeset!

@danwenzel danwenzel force-pushed the add-tree-component branch 3 times, most recently from bb50ce3 to cd3ea17 Compare April 24, 2024 21:36
@danwenzel danwenzel force-pushed the add-tree-component branch from e0a8f07 to 5ed1dc8 Compare April 25, 2024 20:25
@danwenzel danwenzel force-pushed the add-tree-component branch from 5ed1dc8 to fd949ac Compare April 25, 2024 20:29
@danwenzel
Copy link
Collaborator Author

@clintcs @ynotdraw @dylankcrwd - Per discussion with Tony, I went ahead and removed the 3-dot menu for now, as I've run into challenges with architecting it the right way. We'll split that into a separate PR

Other than that, I think I've covered all review comments, if you'd like to take one more look before merging

@clintcs
Copy link
Collaborator

clintcs commented Apr 26, 2024

@danwenzel: Looks good to me!

@ynotdraw
Copy link
Collaborator

Yup, :shipit: !

@danwenzel danwenzel merged commit df88685 into main Apr 26, 2024
7 checks passed
@danwenzel danwenzel deleted the add-tree-component branch April 26, 2024 15:19
@github-actions github-actions bot mentioned this pull request Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants