Mechanical arm optimizations #8613
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-Lazy updating during SEARCH_INPUTS phase so as to not make the arm search for targets on every tick. This should help with performance with many arms or arms that have lots of targets -Replaced if-else-if blocks that checked the arm's Phase with Switch statements -Cached getSlotCount result for arm interaction point slot iterations, should help when iterating high slot counts
VoidLeech
added
the
pr type: feature
Jozufozu
requested changes
Jun 7, 2025
| @@ -54,10 +54,16 @@ | |||
|
|
|||
| public class ArmBlockEntity extends KineticBlockEntity implements TransformableBlockEntity { | |||
|
|
|||
| // Server Statics | |||
| private static final int SearchInputsRate = 20; // the rate at which the arm will search for targets while in SEARCH_INPUTS phase | |||
There was a problem hiding this comment.
Suggested change
| private static final int SearchInputsRate = 20; // the rate at which the arm will search for targets while in SEARCH_INPUTS phase | |
| private static final int SEARCH_INPUTS_RATE= 20; // the rate at which the arm will search for targets while in SEARCH_INPUTS phase |
same for the other static field
| case DANCING: | ||
| boolean forcedSearch = forceSearchInputsTicks > 0; | ||
| if (forcedSearch || (level.getGameTime() + randomSearchTickOffset) % SearchInputsRate == 0) { | ||
| if(forcedSearch) { |
There was a problem hiding this comment.
Suggested change
| if(forcedSearch) { | |
| if (forcedSearch) { |
| case SEARCH_INPUTS: | ||
| case DANCING: | ||
| boolean forcedSearch = forceSearchInputsTicks > 0; | ||
| if (forcedSearch || (level.getGameTime() + randomSearchTickOffset) % SearchInputsRate == 0) { |
There was a problem hiding this comment.
Should probably make it clear in the comments above that the offset will be modulo'd and explain why
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-Lazy updating during SEARCH_INPUTS phase so as to not make the arm search for targets on every tick. This should help with performance with many arms or arms that have lots of targets. I set the update rate to every 20 ticks (so 1 second), a too high of a number might make the arms feel unresponsive. I decided to add a short period after the arm inserts an item to search for targets on every tick, so the arm will try to act right after it inserted an item
-Replaced if-else-if blocks that checked the arm's Phase with Switch statements
-Cached getSlotCount result for arm interaction point slot iterations, should help when iterating high slot counts
-Added comments to explain what i was trying to achieve/how the changes work