When the packager unpacks items, some items will disappear

[donywang922]

Description

The calculation method of slot capacity in PackagerBlockEntity class is different when simulate and actually inserting. According to the code in 1.21.1-dev, in line 401 of PackagerBlockEntity class, MaxStackSize / 64 * getSlotLimit is used as the maximum capacity of the slot, while min(getMaxStackSize, getSlotLimit) is used when calling targetInv.insertItem. Start from 1.21, the default value of getSlotLimit is 99, which results in 35 more capacity per slot in simulation, and eventually causes the packager to try to insert too many items into the container.

Game Log

Debug Information

[donywang922]

QQ202532-232934.mp4

[randarenko]

Also happens with every storage container. Once there are 6 slots free, packager is able to unpack a full package (9 stacks) destroying 3 stacks in the process.

[randarenko]

It is a really annoying bug, and from how it looks not the hardest one to fix. Is there a way to bump it up?

[VoidLeech]

PRs are generally always welcome if you have a fix (:
Otherwise, as you can see there's a lot of open issues that all require looking into. I've tacked the confirmed label on this now that I had a quick test reproducing it. It'll be looked into eventually.

[randarenko]

I do understand that, and have have so much respect for what you guys are doing. Since it had no confirmed label I assumed it was missed along hundreds of other issues, so question was about bringing it up in the feed, not hurrying you up.

[FreudianFondue]

Same here, just spent the last 5 hours racking my brain at where all my iron nuggets went, proceeded to test and can confirm this is happening. I've tested on 1.21.1 6.0.3 and 6.0.4 on Neoforge 21.1.133. Wish I'd have checked the currently open tickets although It took me a while to figure out what was actually happening. I tested with barrels both processing packages through frogports and manually and then having the barrels empty slowly, meaning the moment enough slots for the packager to recognise as it being valid it happens.