-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: game activity tracker #36
Conversation
7538060
to
fdb4154
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Marked somethings, could have marked more, but don't really want to, if it works, whatevs.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also need to solve the eslint issues with const
instead of let
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay so I haven't looked in to all the detail yet
I am currently in a lecture
mostly moving stuff would be great
I can also move them if you want
I also want to test some stuff
Co-authored-by: Wilson <[email protected]>
Co-authored-by: Wilson <[email protected]>
Co-authored-by: Wilson <[email protected]>
Co-authored-by: Wilson <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay I looked over pretty much everything and I am happy with how it is now :)
awesome job floschy! thank you so much :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nothing important to fix, so I'mma approve and you can fix if you want
@@ -57,9 +58,12 @@ export async function adminWhitelistgame(interaction: ChatInputCommandInteractio | |||
let blacklistedGames: string[] | undefined = activityTrackerBlacklistDb.get("general-game"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could avoid this entire erorr handler below, by switching get to ensure
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@WilsontheWolf don't really know enmap
if its important to you just add it and feel free to merge after that :)
* tracking options in config * creating db entry * added indent for updatePresent * Tracking done - 7 commands & 2 autocompletes to go * prevent "Must be 25 or fewer in length" error * activated logging again * map length protection + blacklistRemove completer * blacklist + look commands * All comands Complete * added interface * All autocompletes done * Prettier * fix: eslint-prettier conflict preventing merge * fix: merge mistakes * Did Anttis things, and ig it works now? its late I need sleep * Prettier * ESLint error fix (maybe) * workflow please work * changed to final channel + trimed time formating * format * fix eslint warnings * moved functions to Utils * buttons misc + use it * made admin and statistic commands ephemeral * removed useless imports * small tweaks * prettify * No logging in to chat * prevent duplicates in autocomplete * better * autocomplete for admin -> blacklistgame * lowercase blacklist stuff * new Descriptions+list cmd+blacklist add a-complete * listing logic * removed async * list command stuff * prettier * Wow, I figured out there is an prettify command :O * finished Tracker * stop bot activity to get logged * page fix * fixed wrong user amount * button features, layout stuff and some other things * Wilson did a thing Co-authored-by: Wilson <[email protected]> * Wilson did a thing 2 Co-authored-by: Wilson <[email protected]> * yes Co-authored-by: Wilson <[email protected]> * thx Co-authored-by: Wilson <[email protected]> * configurable Admin command permission * wrong game/user count fix * unused import * prettify * register can be boolean now * GuildPresences intent only when needed * prettify.......... * Uniform file names * fix: git hook... * prettify * revised code and styled a bit * dynamic jumps Co-authored-by: Antti <[email protected]> Co-authored-by: Murphy <[email protected]> Co-authored-by: Murphy <[email protected]> Co-authored-by: Wilson <[email protected]>
Game activity Tracker done