Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: game activity tracker #36

Merged
merged 62 commits into from
Nov 2, 2022
Merged

feat: game activity tracker #36

merged 62 commits into from
Nov 2, 2022

Conversation

flloschy
Copy link
Contributor

Game activity Tracker done

@Chicken Chicken changed the title Game activity tracker feat: game activity tracker Oct 16, 2022
@Chicken Chicken force-pushed the gameActivityTracker branch from 7538060 to fdb4154 Compare October 16, 2022 18:29
Copy link
Contributor

@Chicken Chicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marked somethings, could have marked more, but don't really want to, if it works, whatevs.

Copy link
Contributor

@Chicken Chicken left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to solve the eslint issues with const instead of let

Copy link
Member

@StrangeGirlMurph StrangeGirlMurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay so I haven't looked in to all the detail yet
I am currently in a lecture
mostly moving stuff would be great
I can also move them if you want
I also want to test some stuff

Copy link
Member

@StrangeGirlMurph StrangeGirlMurph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay I looked over pretty much everything and I am happy with how it is now :)
awesome job floschy! thank you so much :)

Copy link
Contributor

@WilsontheWolf WilsontheWolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nothing important to fix, so I'mma approve and you can fix if you want

@@ -57,9 +58,12 @@ export async function adminWhitelistgame(interaction: ChatInputCommandInteractio
let blacklistedGames: string[] | undefined = activityTrackerBlacklistDb.get("general-game");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could avoid this entire erorr handler below, by switching get to ensure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@WilsontheWolf don't really know enmap
if its important to you just add it and feel free to merge after that :)

@StrangeGirlMurph StrangeGirlMurph merged commit ff8ac40 into main Nov 2, 2022
@StrangeGirlMurph StrangeGirlMurph deleted the gameActivityTracker branch November 2, 2022 20:53
StrangeGirlMurph added a commit that referenced this pull request Jan 13, 2023
* tracking options in config

* creating db entry

* added indent for updatePresent

* Tracking done - 7 commands & 2 autocompletes to go

* prevent "Must be 25 or fewer in length" error

* activated logging again

* map length protection + blacklistRemove completer

* blacklist + look commands

* All comands Complete

* added interface

* All autocompletes done

* Prettier

* fix: eslint-prettier conflict preventing merge

* fix: merge mistakes

* Did Anttis things, and ig it works now? its late I need sleep

* Prettier

* ESLint error fix (maybe)

* workflow please work

* changed to final channel + trimed time formating

* format

* fix eslint warnings

* moved functions to Utils

* buttons misc + use it

* made admin and statistic commands ephemeral

* removed useless imports

* small tweaks

* prettify

* No logging in to chat

* prevent duplicates in autocomplete

* better

* autocomplete for admin -> blacklistgame

* lowercase blacklist stuff

* new Descriptions+list cmd+blacklist add a-complete

* listing logic

* removed async

* list command stuff

* prettier

* Wow, I figured out there is an prettify command :O

* finished Tracker

* stop bot activity to get logged

* page fix

* fixed wrong user amount

* button features, layout stuff and some other things

* Wilson did a thing

Co-authored-by: Wilson <[email protected]>

* Wilson did a thing 2

Co-authored-by: Wilson <[email protected]>

* yes

Co-authored-by: Wilson <[email protected]>

* thx

Co-authored-by: Wilson <[email protected]>

* configurable Admin command permission

* wrong game/user count fix

* unused import

* prettify

* register can be boolean now

* GuildPresences intent only when needed

* prettify..........

* Uniform file names

* fix: git hook...

* prettify

* revised code and styled a bit

* dynamic jumps

Co-authored-by: Antti <[email protected]>
Co-authored-by: Murphy <[email protected]>
Co-authored-by: Murphy <[email protected]>
Co-authored-by: Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants