Fix extrapolation #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
There was a problem hiding this comment.
Pull Request Overview
This PR addresses the extrapolation issue by introducing a new bounds_error parameter into the interpolation functions and propagating it through the model and test pipelines.
- Added the bounds_error parameter to functions in unpack_model.py and model.py
- Fixed a spelling error in variable naming from "paramameter" to "parameter"
- Updated test strategies to randomly configure extrapolation via the new parameter
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| zodipy/unpack_model.py | Propagated the new bounds_error parameter, applied it consistently in interpolation calls, and fixed a typo. |
| zodipy/model.py | Added bounds_error handling when initializing the model and invoking the unpack function. |
| tests/strategies.py | Modified test inputs to account for extrapolation behavior, ensuring test coverage for new extrapolation scenarios. |
|
Hi @asabyr! Sorry for taking some time before attempt to fix the issue. I have implemented your suggestion in this PR and from some quick tests the extrapolation should be working. Let me know if anything is missing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Background
Extrapolation is not working at the moment as pointed out in #42.
Solution
Implement the suggestions from #45 and add new tests covering extrapolation