-
Notifications
You must be signed in to change notification settings - Fork 17
Fresh setup #198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fresh setup #198
Conversation
- drop setup.py & setup.cfg - use pyproject.toml - remove deprecated config code
bump2version being deprecated, bump-my-version is a maintained fork.
- add pre-commit - use black, ruff & mypy via pre-commit - fix some lint issues catched by ruff
- drop scripts folder - add Makefile - add dev optional dependency - remove all requirements files - generate new requirements-dev.txt
- debug-statements - vulture (and drop RUF100
I would argue against keeping the requirements-dev.txt Edit: after digging a bit more, the method used in httpx project might be the one I prefer: https://github.com/encode/httpx/blob/master/requirements.txt#L1-L5 |
Totally fair point. As discussed on the side, I was tempted to drop the requirements-dev.txt file as well before reconsidering it to avoid too much change in the CI / dev workflow. That said, I 💯 agree with the deprecation of the |
40aa993
to
dbb84ed
Compare
dbb84ed
to
1b11eeb
Compare
- only hard-pin test dependencies - add/update/drop Makefile recipes - adapt github workflows
1b11eeb
to
358ceb6
Compare
PTAL @tbascoul |
Hi 👋
This PR attempts to clean things a bit concerning the dev, CI and releases workflows.
It tries to stay ISO-functional while adding some niceties:
While working on this PR, several issues have been encountered but not yet solved:
Looking forward to your feedback on this one,
Feel free to review it commit by commit, as I tried to split the work as much as possible 🙏