library settings: allow extra #196
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi 👋
This PR's only aim is to allow extra fields as part of
LibrarySettings
.This feature comes from the fact that we should be able to store custom settings when instantiating a
ModelLibrary
with aLibrarySettings
.A few use-cases I have come across:
aiohttp
ClientSession
to all async models of myModelLibrary
, as recommended by the referenceLooking forward to your feedback