-
Notifications
You must be signed in to change notification settings - Fork 17
Pickable storage driver clients #173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pickable storage driver clients #173
Conversation
at s3 storage driver initialization
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nicely done.
It would be nice to document the new usage it enables !
@ldeflandre sorry for the missing documentation 🤦 |
Good job ! I'm wondering the use-case differences between |
I would like to wait for @tgenin's approval before merging |
@llin17 that's a good remark thanks! Actually the two mechanisms have different goals, and you might want to allow the |
Thanks ! What do you think if we set the default value of |
Very nice feature, thank you @antoinejeannot |
b67c989
Thanks for your pretty relevant remarks as always @tgenin, please take a look at the latest commit 🙏 |
b65fc4b
b65fc4b
to
1b8e5a4
Compare
Hi !
This PR aims at adding a way to pickle the
ModelLibrary
which, for the moment, is impossible due to storage drivers (especially boto3 and gcs).It introduces a
MODELKIT_LAZY_DRIVER
environment variable which, if set, will prevent theStorage Providers
from storing the drivers (boto3, gcs, azure), instead, the configuration settings will be stored allowing the correspondingStorage Provider
to build it on the fly.This will make way easier the use of python libraries which use
pickle
such as Apache Spark and multi-processing, leveraging modelkit.Thanks for reviewing, as always!