Add peerDAS kzg batch verification metric #9415
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zilm13
reviewed
May 13, 2025
| metricsSystem, | ||
| timeProvider, | ||
| TekuMetricCategory.BEACON, | ||
| "kzg_verification_data_column_batch_seconds", |
There was a problem hiding this comment.
If you need one metric in several places, please define it only once and reuse, see
zilm13
reviewed
May 14, 2025
| return completedFuture(reject("DataColumnSidecar does not pass kzg validation")); | ||
| } | ||
| } catch (final Throwable t) { | ||
| throw new RuntimeException(t); |
There was a problem hiding this comment.
Do the same: return completedFuture(reject("DataColumnSidecar does not pass kzg validation"));
| return completedFuture(reject("DataColumnSidecar does not pass kzg validation")); | ||
| } | ||
| } catch (final Throwable t) { | ||
| throw new RuntimeException(t); |
There was a problem hiding this comment.
reject by the same reason if it didn't pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
Add PeerDAS
beacon_kzg_verification_data_column_batch_secondsmetric to align with beacon metrics specsDocumentation
doc-change-requiredlabel to this PR if updates are required.Changelog