Distributed cell proofs #9343
Distributed cell proofs #9343
Conversation
…nd reconstruction
| @@ -22,6 +22,7 @@ | |||
| import tech.pegasys.teku.spec.datastructures.type.SszKZGCommitment; | |||
| import tech.pegasys.teku.spec.datastructures.type.SszKZGProof; | |||
|
|
|||
| // TODO: FULU with cell proofs | |||
There was a problem hiding this comment.
My understanding is that the only meaningful change in this object was the now strict length of all list fields? What is this TODO about?
There was a problem hiding this comment.
Also, do we need to update BlobsBundleSchema with the update size for the proofs (FIELD_ELEMENTS_PER_EXT_BLOB * MAX_BLOB_COMMITMENTS_PER_BLOCK)?
There was a problem hiding this comment.
we don't have builder specs (or maybe I've not seen it yet), not sure
I don't want to change BlobsBundleSchema, I've separate BlobsCellBundleSchema
| public List<DataColumnSidecar> constructDataColumnSidecars( | ||
| @VisibleForTesting | ||
| @Deprecated | ||
| public List<DataColumnSidecar> constructDataColumnSidecarsOld( |
There was a problem hiding this comment.
This is only used by tests now. Can we get rid of it?
There was a problem hiding this comment.
In separate pr please
| @@ -94,7 +94,7 @@ void sanityTest() throws Exception { | |||
| Stream.generate(dataStructureUtil::randomValidBlob).limit(blobCount).toList(); | |||
| BeaconBlock block = blockResolver.addBlock(10, blobCount); | |||
| List<DataColumnSidecar> sidecars = | |||
| miscHelpers.constructDataColumnSidecars(createSigned(block), blobs, kzg); | |||
| miscHelpers.constructDataColumnSidecarsOld(createSigned(block), blobs, kzg); | |||
| @@ -130,7 +130,7 @@ void sanityTest() { | |||
| List<Blob> blobs = Stream.generate(dataStructureUtil::randomValidBlob).limit(1).toList(); | |||
| BeaconBlock block = blockResolver.addBlock(10, 1); | |||
| List<DataColumnSidecar> sidecars = | |||
| miscHelpers.constructDataColumnSidecars(createSigned(block), blobs, kzg); | |||
| miscHelpers.constructDataColumnSidecarsOld(createSigned(block), blobs, kzg); | |||
There was a problem hiding this comment.
I don't see other way to construct proofs for fixtures. And we need proofs to construct valid DataColumnSidecars. Did I miss other way to do this? Deprecated mark is mostly to avoid anyone to call this in production
| @@ -102,6 +103,13 @@ public KZGProof computeBlobKzgProof(final Bytes blob, final KZGCommitment kzgCom | |||
| throw new RuntimeException("LibPeerDASKZG library doesn't support computeBlobKzgProof"); | |||
| } | |||
|
|
|||
| // TODO: test | |||
There was a problem hiding this comment.
Do you plan to test it as part of this PR? Otherwise it would be good to add a ticket link here so we know we won't miss it.
| @Deprecated(since = "Use computeCells instead, computeCellsAndProof is not for production") | ||
| List<KZGCellAndProof> computeCellsAndProofs(Bytes blob); |
There was a problem hiding this comment.
Is this method needed? Why can't we delete it?
| @@ -102,21 +102,27 @@ public KZGProof computeBlobKzgProof(final Bytes blob, final KZGCommitment kzgCom | |||
| return ckzg4844Delegate.computeBlobKzgProof(blob, kzgCommitment); | |||
| } | |||
|
|
|||
| @Override | |||
| public List<KZGCell> computeCells(final Bytes blob) { | |||
| // TODO: replace with RustKZG when available | |||
There was a problem hiding this comment.
Where are we tracking this? We are probably gonna forget...
There was a problem hiding this comment.
it's done, just outdated todo, thank you for catching it
|
So debts, I want to do in separate PR:
|
PR Description
Distributed cell proofs as of:
ethereum/execution-apis#630
ethereum/EIPs#9378
ethereum/consensus-specs#4128
ethereum/consensus-specs#4187
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog