CBST2-04: Update JWT secrets on reload and revoke module endpoint #295
+773
−123
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ltitanb
requested changes
Jul 8, 2025
ltitanb
requested changes
Jul 9, 2025
crates/signer/src/service.rs
Outdated
| @@ -201,7 +214,7 @@ fn check_jwt_rate_limit(state: &SigningState, client_ip: &IpAddr) -> Result<(), | |||
| } | |||
|
|
|||
| /// Checks if a request can successfully authenticate with the JWT secret | |||
| fn check_jwt_auth( | |||
| async fn check_jwt_auth( | |||
There was a problem hiding this comment.
this doesn't need to be async anymore
There was a problem hiding this comment.
Fixed ce562de
| ) -> Result<Response, SignerModuleError> { | ||
| let jwt: Jwt = auth.token().to_string().into(); | ||
|
|
||
| validate_admin_jwt(jwt, &state.admin_secret.read()).map_err(|e| { |
There was a problem hiding this comment.
as a sanity check is the read guard dropped immediately after the function?
There was a problem hiding this comment.
The lock is dropped immediately in case of an Ok() result. In other case, the lock will be kept in the map_err closure, which only logs an error. Would you prefer it to immediately drop in either case?
Co-authored-by: eltitanb <[email protected]> Co-authored-by: ltitanb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now the
reloadendpoint on the signer module allows to update the JWT secrets too.Also, a new
revoke_moduleendpoint was added, to quickly remove the permissions for a compromised module.This two endpoints are now under a new middleware that validates a special "admin" JWT, whose secret is autogenerated on the
initcommand.