[System Pop Up] Hide hidden and deprecated settings from search results #4390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes setting search to exclude hidden and deprecated settings from results, maintaining consistency with the normal settings tree behavior.
Changes
useSettingSearch.tsto exclude settings withtype: 'hidden'ordeprecated: trueBefore
Hidden and deprecated settings appeared in search results even though they're not shown in the normal settings tree.
After
Search results now only show visible, non-deprecated settings, matching the expected behavior.
┆Issue is synchronized with this Notion page by Unito