Skip to content

[System Pop Up] Add setting to disable version update notifications #4388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

bmcomfy
Copy link
Contributor

@bmcomfy bmcomfy commented Jul 8, 2025

Changes

  • Added a new user setting "Show version updates" in Notification Preferences
  • Users can now disable notifications for new models and major feature updates
  • Setting defaults to enabled (true) to maintain current behavior
  • Fixed show toast logic for releases

Implementation Details

  • Added Comfy.Notification.ShowVersionUpdates setting with localization support
  • Updated release store to respect the new notification preference
  • Added UI toggle in Help Center menu
  • Updated API schema to include the new setting

Testing

  • Added comprehensive unit tests for release store functionality
  • Added playwright tests for release notifications behavior
  • All existing tests continue to pass

Files Modified

  • src/constants/coreSettings.ts - Added new setting definition
  • src/components/helpcenter/HelpCenterMenuContent.vue - Added UI toggle
  • src/stores/releaseStore.ts - Updated notification logic
  • src/locales/en/settings.json - Added localization
  • src/schemas/apiSchema.ts - Updated API schema
  • Test files for comprehensive coverage

┆Issue is synchronized with this Notion page by Unito

@bmcomfy bmcomfy requested review from Yorha4D, KarryCharon, shinshin86 and a team as code owners July 8, 2025 19:21
@bmcomfy bmcomfy force-pushed the system-pop-up/add-setting-to-disable-notifications branch from f148d55 to 036c8bc Compare July 8, 2025 21:12
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for adding tests

@christian-byrne christian-byrne merged commit d6f6407 into main Jul 8, 2025
16 of 19 checks passed
@christian-byrne christian-byrne deleted the system-pop-up/add-setting-to-disable-notifications branch July 8, 2025 21:43
This was referenced Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants