Skip to content

[System Pop Up] Improve help center menu behavior and Electron compatibility #4330

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 2, 2025
Merged

[System Pop Up] Improve help center menu behavior and Electron compatibility #4330

merged 4 commits into from
Jul 2, 2025

Conversation

bmcomfy
Copy link
Contributor

@bmcomfy bmcomfy commented Jul 2, 2025 •
edited
Loading

Changes

  • Fix menu item visibility for Electron-specific features
  • Close help center menu automatically after action selection
  • Update help & feedback action to use core commands instead of direct Discord link
  • Hide unavailable menu items instead of showing them as disabled
  • Improve submenu positioning and item management

Details

  • Menu items now properly hide based on environment (web vs Electron)
  • All menu actions now emit close event for better UX
  • Submenu items are filtered by visibility rather than disabled state
  • Help & feedback now triggers the proper feedback command

Fixes: Menu behavior inconsistencies in help center, particularly for Electron desktop users

@bmcomfy bmcomfy requested a review from a team as a code owner July 2, 2025 15:02
@bmcomfy bmcomfy changed the title [System Pop Up] Improve help center popup menu behavior and actions [System Pop Up] Improve help center menu behavior and Electron compatibility Jul 2, 2025
christian-byrne
christian-byrne approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one suggestion.

@christian-byrne christian-byrne merged commit a457534 into main Jul 2, 2025
10 checks passed
@christian-byrne christian-byrne deleted the system-pop-up branch July 2, 2025 23:13
comfy-jinyi pushed a commit that referenced this pull request Jul 4, 2025
@bmcomfy @viva-jinyi
[System Pop Up] Improve help center menu behavior and Electron compat…
e1c0d29 
…ibility (#4330)
This was referenced Jul 9, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christian-byrne christian-byrne christian-byrne approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bmcomfy @christian-byrne