[feat] Add ESLint i18n enforcement and fix hardcoded strings #4327
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds @intlify/eslint-plugin-vue-i18n with smart configuration to enforce internationalization in Vue components. Fixed all existing hardcoded strings by adding proper translation keys and using () calls. - Ignores symbols, single characters, and technical terms - Blocks hardcoded user-facing strings with ESLint error - Added translation keys for install paths, model metadata, loading states - Works with existing pre-commit and CI workflows
christian-byrne
requested review from
Yorha4D,
KarryCharon,
shinshin86 and
a team
as code owners
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
christian-byrne
commented
Jul 2, 2025
…rings These refer to Windows directory paths (AppData folder) and should remain in English as they're technical file system references.
webfiltered
approved these changes
Jul 2, 2025
comfy-jinyi
pushed a commit
that referenced
this pull request
Jul 4, 2025
Co-authored-by: github-actions <[email protected]>
comfy-jinyi
pushed a commit
that referenced
this pull request
Jul 4, 2025
Co-authored-by: github-actions <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds @intlify/eslint-plugin-vue-i18n to enforce internationalization in Vue components and fixes all existing hardcoded strings.
Key features:
If run on entire codebase without fixes, this would show errors on these lines:
All violations have been fixed by adding translation keys to main.json and updating components to use () calls.
┆Issue is synchronized with this Notion page by Unito