-
Notifications
You must be signed in to change notification settings - Fork 317
Add API usage log table #4288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API usage log table #4288
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Can we just add tests for the service and the UsageLogsTable.vue
?
- Examples of service unit tests: https://github.com/Comfy-Org/ComfyUI_frontend/tree/main/tests-ui/tests/services
- Guide for writing component tests: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/tests-ui/component-testing.md
- Example of component test: https://github.com/Comfy-Org/ComfyUI_frontend/blob/main/src/components/common/TreeExplorerTreeNode.spec.ts
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Tests failed once this was merged to main: https://github.com/Comfy-Org/ComfyUI_frontend/actions/runs/15981619587/job/45077170846 |
@webfiltered I checked the test log, I don't see any error related to this changes, it is saying something:
|
For Viewport settings › Keeps viewport settings when changing tabs, it is unrelated to this PR. The release notes will popup but the timing is naturally inconsistent in test environment |
Let me handle the test errors. They are actually all from the popup in the bottom left, which sometimes appears and sometimes does not:
|
Co-authored-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
Co-authored-by: github-actions <[email protected]>
added usage log table inside credit page:

please notice, some code come from existing website repo
┆Issue is synchronized with this Notion page by Unito