Skip to content

Add API usage log table #4288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Jun 30, 2025
Merged

Add API usage log table #4288

merged 9 commits into from
Jun 30, 2025

Conversation

jtydhr88
Copy link
Collaborator

@jtydhr88 jtydhr88 commented Jun 28, 2025

added usage log table inside credit page:
image
please notice, some code come from existing website repo

┆Issue is synchronized with this Notion page by Unito

@jtydhr88 jtydhr88 requested review from Yorha4D, KarryCharon, shinshin86 and a team as code owners June 28, 2025 03:08
@benceruleanlu benceruleanlu self-requested a review June 29, 2025 02:03
@benceruleanlu benceruleanlu removed their request for review June 29, 2025 20:19
Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@christian-byrne christian-byrne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@christian-byrne christian-byrne merged commit 5bbed91 into main Jun 30, 2025
10 checks passed
@christian-byrne christian-byrne deleted the usage-log branch June 30, 2025 19:13
@webfiltered webfiltered changed the title usage log table Add API usage log table Jun 30, 2025
@webfiltered
Copy link
Contributor

@jtydhr88
Copy link
Collaborator Author

@webfiltered I checked the test log, I don't see any error related to this changes, it is saying something:
[chromium] › browser_tests/tests/widget.spec.ts:181:3 › Image widget › Can change image by changing the filename combo value

Test timeout of 15000ms exceeded.

Error: locator.click: Test timeout of 15000ms exceeded.
Call log:
  - waiting for getByRole('menuitem', { name: 'image32x32.webp' })


  194 |       name: 'image32x32.webp'
  195 |     })
> 196 |     await comboEntry.click({ noWaitAfter: true })
      |                      ^
  197 |
  198 |     // Expect the image preview to change automatically
  199 |     await expect(comfyPage.canvas).toHaveScreenshot(
    at /home/runner/work/ComfyUI_frontend/ComfyUI_frontend/ComfyUI_frontend/browser_tests/tests/widget.spec.ts:196:22

@christian-byrne
Copy link
Contributor

christian-byrne commented Jun 30, 2025

For Viewport settings › Keeps viewport settings when changing tabs, it is unrelated to this PR. The release notes will popup but the timing is naturally inconsistent in test environment

Selection_1632

@christian-byrne
Copy link
Contributor

christian-byrne commented Jun 30, 2025

Let me handle the test errors. They are actually all from the popup in the bottom left, which sometimes appears and sometimes does not:

  • Viewport test: Screenshot shows "ComfyUI v0.3.43 Release" popup not present in expected image
  • Workflows test: Error explicitly states <h1>ComfyUI v0.3.43 Release</h1> intercepts pointer events
  • Node library test: Drag-and-drop fails because popup is blocking the bottom-left area

christian-byrne pushed a commit that referenced this pull request Jul 2, 2025
Co-authored-by: github-actions <[email protected]>
lordTyrion pushed a commit to playbook3d/ComfyUI_frontend that referenced this pull request Jul 2, 2025
comfy-jinyi pushed a commit that referenced this pull request Jul 4, 2025
Co-authored-by: github-actions <[email protected]>
This was referenced Jul 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants