Skip to content

fixing storybook setup #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 35 commits into from
Oct 29, 2024

Conversation

ElzabeEls
Copy link
Collaborator

No description provided.

@ElzabeEls
Copy link
Collaborator Author

To use Storybook correctly. One has to create your own fake data as in this example, or use the sample data as was set up in the previous example. Let me know which one you prefer.

Copy link
Collaborator

@IkanyengAdams IkanyengAdams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request introduces several enhancements and features to the product detail page, including the successful implementation of recipe names and descriptions, as well as the addition of preparation, cooking, and total time fields for improved user understanding. Recipe tags have been integrated for better categorization and searchability, and recipe images have been added to enhance visual appeal. Additionally, unnecessary comments have been removed from the product detail page for clarity, and a carousel component has been incorporated within the RecipeCard to facilitate navigation through recipes. The loading state management has been centralized directly under the app, and standard colors have been configured in the settings file to ensure consistency. Various styling changes have been made to the recipe cards for a more polished appearance, along with the addition of error handling in the RecipeDetail function, which now includes a retry button to improve user experience during API failures. Furthermore, API functions have been updated to support pagination and enhanced error handling. Storybook setup issues have been addressed, updates to page.js have been made to align with best practices, and Tailwind CSS has been integrated for styling improvements. Lastly, linting rules have been updated and enforced by modifying the linting.yml configuration file to maintain code quality.

Copy link
Collaborator

@NeoPhetoane NeoPhetoane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Linting, storybook, endpoint edited, This workflow setup is well-optimized, covering dependencies, linting, building, and testing.
Configuration is set up for consistent global styling and Storybook controls
API route for fetching paginated recipes from MongoDB is well-structured and includes helpful comments.
Carousel is user-friendly and visually appealing.
SVG component makes svgs more versatile and accessible, making it easier to reuse in different contexts.
Styling improved in RecipeCard.
Button component looks good, and it's following standard practices for a styled, customisable button.
Header, RecipeCard and Page.js stories added for testing.
Pagination controls effectively paginate
RecipeDetail component is well-structured and effectively displays detailed information about a recipe.
fetchRecipes and fetchProductById functions are well-structured and provide clear documentation

Comments: Update comments if necessary to maintain clarity.

@IkanyengAdams IkanyengAdams merged commit d41dc3e into CodeSpace-Academy:main Oct 29, 2024
ElzabeEls added a commit that referenced this pull request Oct 29, 2024
bringing over changes from old repo
ElzabeEls added a commit that referenced this pull request Oct 29, 2024
Merge pull request #134 from CodeSpace-Academy/main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants