Skip to content

Handle errors on recipe detail page #96 #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 23, 2024
Merged

Handle errors on recipe detail page #96 #121

merged 3 commits into from
Oct 23, 2024

Conversation

ElzabeEls
Copy link
Collaborator

No description provided.

OmphileMorwane
OmphileMorwane approved these changes Oct 23, 2024
View reviewed changes
Copy link
Contributor

@OmphileMorwane OmphileMorwane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is clean, and the implementation of animations and error handling adds to a polished user experience.
Suggestions: Consider adding unit tests for these components to ensure their behavior, especially animations and the error handling logic

@OmphileMorwane OmphileMorwane merged commit 95ea7bd into main Oct 23, 2024
0 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Moosa-24 Moosa-24 Moosa-24 approved these changes

@OmphileMorwane OmphileMorwane OmphileMorwane approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ElzabeEls @Moosa-24 @OmphileMorwane @HloleloRampete