Skip to content

Rename Model to IncompressibleModel #626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Feb 19, 2020
Merged

Conversation

ali-ramadhan
Copy link
Member

@ali-ramadhan ali-ramadhan commented Feb 15, 2020

Note: This PR branches off from #621.

Resolves #566
Resolves #633

@ali-ramadhan ali-ramadhan added the cleanup 🧹 Paying off technical debt label Feb 15, 2020
@codecov
Copy link

codecov bot commented Feb 15, 2020

Codecov Report

Merging #626 into master will increase coverage by 4.4%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #626     +/-   ##
=========================================
+ Coverage   70.47%   74.87%   +4.4%     
=========================================
  Files         118      118             
  Lines        2259     2277     +18     
=========================================
+ Hits         1592     1705    +113     
+ Misses        667      572     -95
Impacted Files Coverage Δ
src/Utils/launch_config.jl 70.58% <0%> (-29.42%) ⬇️
src/Solvers/pressure_solver.jl 50% <0%> (-2.64%) ⬇️
src/Models/incompressible_model.jl 100% <0%> (ø) ⬆️
src/OutputWriters/checkpointer.jl 90.47% <0%> (+2.38%) ⬆️
...nditions/solution_and_model_boundary_conditions.jl 94.59% <0%> (+5.4%) ⬆️
src/Fields/field.jl 78.68% <0%> (+6.55%) ⬆️
src/Architectures.jl 88.88% <0%> (+22.22%) ⬆️
src/Fields/set!.jl 61.76% <0%> (+26.47%) ⬆️
src/Solvers/plan_transforms.jl 100% <0%> (+33.33%) ⬆️
...c/Solvers/horizontally_periodic_pressure_solver.jl 98.11% <0%> (+56.6%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0f1f5ab...99f7404. Read the comment docs.

@ali-ramadhan
Copy link
Member Author

ali-ramadhan commented Feb 17, 2020

@glwagner Was hoping you could review this PR first as #627 (already approved) branches off from this PR.

This PR is partly responsible for why so many files have changed in subsequent PRs (they all branch off from this PR).

@ali-ramadhan ali-ramadhan merged commit 9964670 into master Feb 19, 2020
@ali-ramadhan ali-ramadhan deleted the ar/incompressible-model branch February 19, 2020 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cleanup 🧹 Paying off technical debt
Projects
None yet
Development

Successfully merging this pull request may close these issues.

README is out of date Should Model be renamed to IncompressibleModel or BoussinesqModel?
2 participants