Skip to content

Differentiated and variable AMD model constants #622

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Feb 11, 2020

Conversation

glwagner
Copy link
Member

This PR differentiates the AMD model constants for eddy viscosity and eddy diffusivity, and permits them to be functions of x, y, z.

For simplicity we will permit just one model constant specification for all tracers. It is possible to permit different constants for different tracers, but

Also, with this PR the "Verstappen" implementation of AMD is now diverging from the "Rozema" implementation. It may be time to nuke the "Rozema" implementation.

@codecov
Copy link

codecov bot commented Feb 11, 2020

Codecov Report

Merging #622 into master will increase coverage by 0.38%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
+ Coverage   74.63%   75.02%   +0.38%     
==========================================
  Files         117      119       +2     
  Lines        2196     2446     +250     
==========================================
+ Hits         1639     1835     +196     
- Misses        557      611      +54
Impacted Files Coverage Δ
src/TurbulenceClosures/turbulence_closure_utils.jl 80% <100%> (ø) ⬆️
...ions/verstappen_anisotropic_minimum_dissipation.jl 94.11% <69.23%> (-5.89%) ⬇️
src/Grids/Grids.jl 57.14% <0%> (-42.86%) ⬇️
src/AbstractOperations/AbstractOperations.jl 25% <0%> (-8.34%) ⬇️
src/Coriolis/f_plane.jl 63.33% <0%> (-6.67%) ⬇️
src/Grids/grid_utils.jl 98.7% <0%> (-1.3%) ⬇️
src/Operators/interpolation_operators.jl 59.01% <0%> (-0.51%) ⬇️
src/Fields/field.jl 78.35% <0%> (-0.34%) ⬇️
src/Coriolis/no_rotation.jl 0% <0%> (ø) ⬆️
src/Grids/vertically_stretched_cartesian_grid.jl 100% <0%> (ø) ⬆️
... and 9 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f4465d...d25abdb. Read the comment docs.

@ali-ramadhan ali-ramadhan merged commit 73bea22 into master Feb 11, 2020
@ali-ramadhan ali-ramadhan deleted the glw/variable-amd-model-constant branch February 11, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants