Differentiated and variable AMD model constants #622
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR differentiates the AMD model constants for eddy viscosity and eddy diffusivity, and permits them to be functions of
x, y, z
.For simplicity we will permit just one model constant specification for all tracers. It is possible to permit different constants for different tracers, but
Also, with this PR the "Verstappen" implementation of AMD is now diverging from the "Rozema" implementation. It may be time to nuke the "Rozema" implementation.