Skip to content

Changes Timeseries to TimeSeries #618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 10, 2020
Merged

Changes Timeseries to TimeSeries #618

merged 2 commits into from
Feb 10, 2020

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Feb 7, 2020

This is a breaking change, so best done sooner rather than later since it is trivial.

A more serious question is whether we should change the semantics of the JLD2OutputWriter, which stores output in a group under the heading "timeseries" (and does not allow this to be changed). It's probably better to revisit the output writers in the broader context of improving the output writer API / functionality, however.

@glwagner glwagner requested a review from ali-ramadhan February 7, 2020 12:20
@codecov
Copy link

codecov bot commented Feb 7, 2020

Codecov Report

Merging #618 into master will increase coverage by 4.58%.
The diff coverage is 77.77%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #618      +/-   ##
==========================================
+ Coverage   69.97%   74.55%   +4.58%     
==========================================
  Files         117      117              
  Lines        2188     2209      +21     
==========================================
+ Hits         1531     1647     +116     
+ Misses        657      562      -95
Impacted Files Coverage Δ
src/Diagnostics/Diagnostics.jl 100% <ø> (ø) ⬆️
src/Diagnostics/time_series.jl 90% <77.77%> (ø)
src/Utils/launch_config.jl 70.58% <0%> (-29.42%) ⬇️
src/Models/model.jl 91.66% <0%> (-8.34%) ⬇️
src/Solvers/pressure_solver.jl 50% <0%> (-2.64%) ⬇️
src/Solvers/solve_for_pressure.jl 100% <0%> (ø) ⬆️
src/OutputWriters/checkpointer.jl 90.47% <0%> (+2.38%) ⬆️
src/Logger.jl 80.95% <0%> (+4.76%) ⬆️
...nditions/solution_and_model_boundary_conditions.jl 94.59% <0%> (+5.4%) ⬆️
src/Fields/field.jl 78.68% <0%> (+6.55%) ⬆️
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e803ac...9698a1a. Read the comment docs.

@ali-ramadhan
Copy link
Member

A more serious question is whether we should change the semantics of the JLD2OutputWriter, which stores output in a group under the heading "timeseries" (and does not allow this to be changed). It's probably better to revisit the output writers in the broader context of improving the output writer API / functionality, however.

Yeah I think that quirk could be confusing and is where NetCDF output files are easier to work with. But NetCDFOutputWriter has other limitations currently, so some re-designing should probably be done. Making the two output writer more similar would be nice.

@ali-ramadhan
Copy link
Member

Merging so this can be part of v0.21.0 (which will include a few other breaking changes).

@ali-ramadhan ali-ramadhan merged commit 11c41e1 into master Feb 10, 2020
@ali-ramadhan ali-ramadhan deleted the glw/time-series branch February 10, 2020 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants