-
Notifications
You must be signed in to change notification settings - Fork 238
Delete leftover JLD2 files before deploying docs #558
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This PR should be merged first before to avoid any more JLD2 files being committed to git history. |
Codecov Report
@@ Coverage Diff @@
## master #558 +/- ##
=======================================
Coverage 67.72% 67.72%
=======================================
Files 69 69
Lines 1952 1952
=======================================
Hits 1322 1322
Misses 630 630 Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reluctant approval.
This is not a good solution, because its useful for users to have the JLD2 file around to play with.
We need to know why such behavior occurs so we can ensure it doesn't happen in the future --- how is the file being added from gh-pages
, when jld2
is ignored in gitignore
?
Actually I think I did it wrong in #524. I'm supposed to delete leftover files after I also feel that Documenter shouldn't even be adding jld2 files. Asking on Julia Slack to see if this is expected behavior and how to avoid it. EDIT: There is no |
I added a This PR now deletes leftover JLD2 files before deploying (just to be safe and also to unclutter the CI server in case we need to cache files between builds). |
Maybe not the cleanest solution but this will resolve #509 which has become a rather annoying issue recently.