Time-stepper cleanup and modularization #505
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… algorithm so new timesteppers can more easily be defined
Codecov Report
@@ Coverage Diff @@
## master #505 +/- ##
=========================================
- Coverage 72.73% 72.33% -0.4%
=========================================
Files 37 39 +2
Lines 1720 1717 -3
=========================================
- Hits 1251 1242 -9
- Misses 469 475 +6
Continue to review full report at Codecov.
|
ali-ramadhan
approved these changes
Oct 27, 2019
arcavaliere
pushed a commit
to arcavaliere/Oceananigans.jl
that referenced
this pull request
Nov 6, 2019
…leanup Time-stepper cleanup and modularization Former-commit-id: 525d5c0
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR moves the time stepping functionality into a module and refactors and orthogonalizes the time-stepping algorithm to make it easier to implement new time steppers.
It also introduces a macro
@loop_xyzthat copy-pastes code to specify a 3D loop, reducing a lot of boiler plate.There is also a new function
compute_w_from_continuity!(model)that a user might employ to ensure their initial velocity field is non-divergent.Resolves #485
Resolves #461
Probably resolves #448