Use a default active cells map for kernel launching #4453
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Curious about the performance implications of this.
I think it is better to do the same thing re: active cells for every kernel, rather than picking and choosing.
The main advantage is the simplicity of the algorithm.
Ultimately I think that the active cells should be part of the KernelParameters. It doesn't make sense to think of the kernel parameters and active map as separate concepts.
It should be automatically computed for the majority of kernels, and only changed for edge cases. I am not sure why there are edge cases, but it seems they exist for halo filling?
cc @simone-silvestri can you help improve this design? Perhaps we can discuss here.
Ironing out these issues will become crucial if we want to use Oceananigans finite volume engine for implementing additional models. I also think a distributed algo refactor needs to come at some point, and this is perhaps the first step.