-
Notifications
You must be signed in to change notification settings - Fork 241
A rework for the advection module that (should) improve WENO performance #4434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
simone-silvestri
wants to merge
202
commits into
main
Choose a base branch
from
ss/optimize-weno
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from 1 commit
Commits
Show all changes
202 commits
Select commit
Hold shift + click to select a range
b07b4e5
FMA
simone-silvestri 1506eed
muladd
simone-silvestri 885e724
add stencils
simone-silvestri 3354386
good stencils
simone-silvestri ce9d408
start with this
simone-silvestri d9a2348
thins kind of works
simone-silvestri 52b332a
start with this
simone-silvestri 362764a
optimize
simone-silvestri a671d18
finished
simone-silvestri dc3935b
remove it
simone-silvestri 483f44a
remove them
simone-silvestri f897264
fix
simone-silvestri bcbdd9c
correct validation
simone-silvestri b1e5a54
keep these as is
simone-silvestri 93564a1
this works!
simone-silvestri 4f98cdb
Merge remote-tracking branch 'origin/ss/remove-stretched-coeffs' into…
simone-silvestri fcae428
don't need this
simone-silvestri 3b4cd39
go ahead
simone-silvestri 9304947
remove redundant loop
simone-silvestri 8e32bc1
this works! NICE!
simone-silvestri 6cf1a0f
Merge branch 'main' into ss/remove-stretched-coeffs
simone-silvestri cfff4c4
flat fluxes
simone-silvestri 0998550
Merge branch 'ss/remove-stretched-coeffs' of github.com:CliMA/Oceanan…
simone-silvestri 3a3213f
flat fluxes
simone-silvestri 5d5ec46
again flat stuff
simone-silvestri c6762b7
flat interpolations
simone-silvestri e3e1c72
biased to symmetric
simone-silvestri af62962
change symmetric
simone-silvestri 390967e
just use this
simone-silvestri a6c534e
Merge remote-tracking branch 'origin/ss/remove-stretched-coeffs' into…
simone-silvestri 4854689
love this
simone-silvestri 472790f
just test it as is?
simone-silvestri 8aab10c
soooo much simpler
simone-silvestri 91d1a90
add a comment
simone-silvestri e3345ff
remove also this one
simone-silvestri 5df779f
adapt order
simone-silvestri af586bd
fixed weno vector invariant
simone-silvestri 84da70e
Merge remote-tracking branch 'origin/ss/remove-stretched-coeffs' into…
simone-silvestri 39c5c2c
make sure the FT is correct
simone-silvestri 5452cb8
a little clarity
simone-silvestri 08ee0c2
add a comment
simone-silvestri 5067e9b
start this
simone-silvestri 2e94c44
adding some fallbacks
simone-silvestri 4cad6eb
just immersed to go!
simone-silvestri 0600e08
amazing
simone-silvestri 20f2ef8
try it like this
simone-silvestri 95cec39
remove this as well
simone-silvestri d707b12
no buffer scheme!
simone-silvestri 74e96b9
test it like this
simone-silvestri 953f26f
small fix
simone-silvestri f32b7fd
test with random
simone-silvestri 424535b
add the val here
simone-silvestri 0c1f11f
this should work now?
simone-silvestri dff2745
just make it work for now
simone-silvestri 6cd21c1
remove this
simone-silvestri ebe429c
test stuff
simone-silvestri dcc2a3c
remove ord
simone-silvestri af3f08b
better
simone-silvestri 89918be
Merge branch 'main' into ss/remove-stretched-coeffs
simone-silvestri 365ce4c
let's go
simone-silvestri 4806bf4
more bugfix
simone-silvestri 7305ade
remove unused stuff
simone-silvestri bf8f021
might try like this
simone-silvestri 3be592f
remove abiguity
simone-silvestri c70a0d8
not sure but try it like this
simone-silvestri b3363c7
ok this seems to work
simone-silvestri 6263c84
Update src/Advection/adapt_advection_order.jl
simone-silvestri 064eaeb
Merge branch 'main' into ss/remove-stretched-coeffs
simone-silvestri 413abd7
removed all runtime dispatch
simone-silvestri 22b8145
remove also the bias
simone-silvestri 5527fe6
more updates
simone-silvestri 5488817
try it out
simone-silvestri 44bb8e3
try like this for the moment
simone-silvestri 51edbf9
back to how it was
simone-silvestri 743740b
more changes
simone-silvestri 6e2db1c
maybe try this?
simone-silvestri 79ecf95
try like this
simone-silvestri bafbc02
try JS weno
simone-silvestri 338cbab
try again with zweno
simone-silvestri 721640f
this should be the same as before?
simone-silvestri 3ebb5f0
back to before
simone-silvestri 89e1c13
this is the whole shabang?
simone-silvestri ee6c409
not used anymore
simone-silvestri c07aa85
this should work egegiously
simone-silvestri a2caeaf
this should never be required?
simone-silvestri d8a09cd
disambiguation
simone-silvestri 1a6f052
fix upwind first order
simone-silvestri 160977c
correct reduced order
simone-silvestri 2905b92
this should work
simone-silvestri 630690f
bugfix
simone-silvestri 06d5867
Merge branch 'ss/remove-stretched-coeffs' of github.com:CliMA/Oceanan…
simone-silvestri 7624703
another bugfix
simone-silvestri 9273b68
this should work now
simone-silvestri c4d0e62
this should work
simone-silvestri 51b245c
ok tests should pass
simone-silvestri 1e2459c
Merge remote-tracking branch 'origin/ss/remove-stretched-coeffs' into…
simone-silvestri 9113cb6
need to figure this out a bit
simone-silvestri c743c86
add smoothness 6
simone-silvestri 372ff8a
unify
simone-silvestri de79e7a
Merge remote-tracking branch 'origin/main' into ss/optimize-weno
simone-silvestri 5c1e159
some changes
simone-silvestri 6914d78
remove stuff
simone-silvestri 77ba861
correct
simone-silvestri 453277b
fix it
simone-silvestri 30af263
this should work
simone-silvestri 5ee703c
add the grid
simone-silvestri f521b52
remove this
simone-silvestri 3c62954
add test
simone-silvestri 81c5896
try like this
simone-silvestri b43a160
try like this
simone-silvestri ba1f01f
only one division
simone-silvestri d35f65c
known at compile time
simone-silvestri 1991aa7
looks better now
simone-silvestri 492490b
use fastmath in correct places
simone-silvestri 3da3fe3
this should not give a nothing
simone-silvestri 672607b
update
simone-silvestri 55d745a
more correction
simone-silvestri eeee9d7
add
simone-silvestri 5525c25
up to 9th order
simone-silvestri f8f2fe0
add some comments
simone-silvestri 825118b
make sure we also account for the immersed boundary
simone-silvestri 2415fd7
accounting fo an immersed boundary
simone-silvestri ab4f0e2
add commenr
simone-silvestri 34aabb0
try with randoms
simone-silvestri 8548855
gotta try like this?
simone-silvestri 6cec08b
remove all the ifelses
simone-silvestri 8545dd9
add fastmath decorator
simone-silvestri 2ea6182
let's go!
simone-silvestri 18e4b1e
these are not required
simone-silvestri 9623a75
chenage if with ifelse
simone-silvestri 939a7fe
forgot the `r`
simone-silvestri 5a2210c
remove 11th order WENO
simone-silvestri 46c7406
add comment
simone-silvestri f2fc7c5
cleanup a bit
simone-silvestri 64648fe
cleanup more
simone-silvestri c86585e
add a comment
simone-silvestri 7a557ff
comment
simone-silvestri 4d3bb89
let's test this as well
simone-silvestri 2771e83
some comments
simone-silvestri fb4dc44
done!
simone-silvestri 76a548c
good comment
simone-silvestri 9dc9d3b
comment
simone-silvestri 198e2f9
align orders
simone-silvestri 826d1c1
small comment
simone-silvestri 9f05b87
change name
simone-silvestri e848dbb
go ahead
simone-silvestri 759d3c0
clearer
simone-silvestri bac291e
small fix
simone-silvestri 71a7228
remove high high order
simone-silvestri 3078cdd
remove WENO 11th
simone-silvestri a9f8062
Add newton_div utility
glwagner 7e17421
add a comment
glwagner dd547c8
Use newton_div in WENO
glwagner 80ce48f
import
glwagner 7152538
unify epsilons
glwagner aed2ac2
short circuit all-F32 div
glwagner 91aa66d
Merge branch 'main' into newton-div
navidcy 6ee3c3e
Update src/Utils/newton_div.jl
glwagner 70ebd05
Update src/Utils/newton_div.jl
glwagner ac43795
Update src/Utils/newton_div.jl
glwagner b1a9c94
Update src/Utils/newton_div.jl
glwagner 3ed606c
Merge branch 'main' into ss/optimize-weno
simone-silvestri 1415298
remove 12th order
simone-silvestri d115c81
Merge branch 'ss/optimize-weno' of github.com:CliMA/Oceananigans.jl i…
simone-silvestri dc5ba56
remove 12th order
simone-silvestri 6dfd3f2
fix it
simone-silvestri 07e4c06
formatting
simone-silvestri a3535be
bugfix
simone-silvestri 6dc5cdf
another bugfix
simone-silvestri c7e0041
try using float32
simone-silvestri 8aa7125
reshuffle
simone-silvestri 12225ce
preparing for removing division
simone-silvestri 6a2009e
add fast math
simone-silvestri 068d4dd
Merge branch 'ss/optimize-weno' of github.com:CliMA/Oceananigans.jl i…
simone-silvestri f6b9a64
Merge branch 'main' into ss/optimize-weno
simone-silvestri 6f644e1
Merge branch 'main' into ss/optimize-weno
simone-silvestri 2f8486c
Merge branch 'main' into ss/optimize-weno
simone-silvestri 6907eab
Merge branch 'main' into ss/optimize-weno
simone-silvestri d2cebe4
just this
simone-silvestri 107701e
Merge branch 'main' into ss/optimize-weno
simone-silvestri effacc3
make it work
simone-silvestri 5109858
merge main
simone-silvestri 6e73cb5
adding epsilon
simone-silvestri d8c3fb6
Merge branch 'ss/optimize-weno' of github.com:CliMA/Oceananigans.jl i…
simone-silvestri 7b89480
Merge branch 'ss/optimize-weno' of github.com:CliMA/Oceananigans.jl i…
simone-silvestri 772e07b
remember the reduced order
simone-silvestri 3fdf27e
will this work?
simone-silvestri 83e1779
fast math for smoothness
simone-silvestri 7d31cff
should go here
simone-silvestri 2e191b1
lower precision smoothness operation
simone-silvestri 5127665
do not need this
simone-silvestri 5a4ebe9
this does not help
simone-silvestri 80ba59d
cast all to single precision
simone-silvestri c22c59c
this unfortunately breaks stuff
simone-silvestri 36b5f72
Merge branch 'main' into ss/optimize-weno
simone-silvestri 16e6050
Merge branch 'main' into ss/optimize-weno
simone-silvestri 69f164a
Merge branch 'main' into ss/optimize-weno
simone-silvestri f14a99e
Merge branch 'main' into ss/optimize-weno
simone-silvestri b2638b9
Merge branch 'main' into ss/optimize-weno
simone-silvestri af70902
Merge branch 'main' into ss/optimize-weno
simone-silvestri a2396c6
Merge branch 'main' into ss/optimize-weno
simone-silvestri a3ca050
Merge branch 'main' into ss/optimize-weno
simone-silvestri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.