Reactant: add make_tracer for grid #4242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@wsmoses good to merge? |
glwagner
reviewed
Mar 19, 2025
|
okay @glwagner this is now good to go if you can give it a re review |
|
GPU tests look like they are failing because of the addition of the |
glwagner
reviewed
Mar 21, 2025
glwagner
reviewed
Mar 21, 2025
|
This PR modifies also main source code, not just extension, right? |
|
Thats right, but we can move it to the extension in a subsequent PR |
|
A main concern is that compile time for the tests has exploded. The four "reactant 2" tests are at 2h now: 
They are all still compiling the first model run (of 2 in that test) |
glwagner
approved these changes
Mar 21, 2025
Co-authored-by: Simone Silvestri <[email protected]>
Co-authored-by: Simone Silvestri <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.