Skip to content

Convert TimeInterpolator indices to Int #4230

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2025
Merged

Convert TimeInterpolator indices to Int #4230

merged 2 commits into from
Mar 17, 2025

Conversation

glwagner
Copy link
Member

This is needed to have indices that are CuTracedRNumber inside kernels like interpolate_atmosphere_state in ClimaOcean.

@glwagner
Copy link
Member Author

To test this we need to make a kernel with arch = ReactantState() that passes a traced TimeInterpolator into it.

I think this will also test the change on #4227

@glwagner glwagner mentioned this pull request Mar 17, 2025
Closed
@glwagner glwagner merged commit a0846c7 into main Mar 17, 2025
53 checks passed
@glwagner glwagner deleted the glw/convert-int-indexing branch March 17, 2025 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@glwagner