Skip to content

Use default FloatType in Centered advection #4193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

Use default FloatType in Centered advection #4193

merged 1 commit into from
Mar 11, 2025

Conversation

glwagner
Copy link
Member

@glwagner glwagner commented Mar 10, 2025 •
edited
Loading

Closes #4192

@glwagner glwagner mentioned this pull request Mar 10, 2025
Closed
ali-ramadhan
ali-ramadhan approved these changes Mar 10, 2025
View reviewed changes
Copy link
Member

@ali-ramadhan ali-ramadhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Seems like this PR makes the code more correct in all cases.

@glwagner glwagner merged commit bc322ca into main Mar 11, 2025
47 of 55 checks passed
@glwagner glwagner deleted the glwagner-patch-3 branch March 11, 2025 05:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ali-ramadhan ali-ramadhan ali-ramadhan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GPU compiler error in tendency computation using DiscreteForcing with GPU + Float32 + immersed RectilinearGrid
2 participants
@glwagner @ali-ramadhan