-
Notifications
You must be signed in to change notification settings - Fork 238
Stratified Couette flow verification #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report
@@ Coverage Diff @@
## master #381 +/- ##
==========================================
+ Coverage 71.65% 72.07% +0.42%
==========================================
Files 26 26
Lines 1418 1418
==========================================
+ Hits 1016 1022 +6
+ Misses 402 396 -6
Continue to review full report at Codecov.
|
Is "verification" just a run script, or do we include analysis as well? Maybe need to have a folder for each verification case? |
Thanks for the comments!
Yeah a folder for each might make sense. I'm envisioning that each verification test case is described in the documentation with enough figures/plots to convince the reader that Oceananigans is doing the right thing. There should be a simulation script (like the one in this PR) that allows the reader to reproduce the simulation, and probably one or more plotting scripts allowing them to recreate the plots. |
test/verification/stratified_couette_flow/stratified_couette_flow.jl
Outdated
Show resolved
Hide resolved
test/verification/stratified_couette_flow/stratified_couette_flow.jl
Outdated
Show resolved
Hide resolved
…s to parameters dict for use in statistics functions
…act that w is vertical velocity
Stratified Couette flow verification Former-commit-id: 211e18c
This PR introduces a script for simulating Stratified Couette flow with the aim of reproducing the LES results of Vreugdenhil & Taylor (2018). See #310 for more details.
When the verification is completely successfully, I will ensure the script is maintained in the
test/verification/
subdirectory so that the verification can be reproduced at any time. I will also convert it to a regression test. See #347.Resolves #310
Resolves #415
Contributes to #346 and #347