Skip to content

Stratified Couette flow verification #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 43 commits into from
Oct 14, 2019
Merged

Conversation

ali-ramadhan
Copy link
Member

@ali-ramadhan ali-ramadhan commented Aug 28, 2019

This PR introduces a script for simulating Stratified Couette flow with the aim of reproducing the LES results of Vreugdenhil & Taylor (2018). See #310 for more details.

When the verification is completely successfully, I will ensure the script is maintained in the test/verification/ subdirectory so that the verification can be reproduced at any time. I will also convert it to a regression test. See #347.

Resolves #310
Resolves #415
Contributes to #346 and #347

@ali-ramadhan ali-ramadhan added science 🌊 Sometimes addictive, sometimes allergenic numerics 🧮 So things don't blow up and boil the lobsters alive testing 🧪 Tests get priority in case of emergency evacuation labels Aug 28, 2019
@ali-ramadhan ali-ramadhan added this to the JOSS milestone Aug 28, 2019
@codecov
Copy link

codecov bot commented Aug 28, 2019

Codecov Report

Merging #381 into master will increase coverage by 0.42%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #381      +/-   ##
==========================================
+ Coverage   71.65%   72.07%   +0.42%     
==========================================
  Files          26       26              
  Lines        1418     1418              
==========================================
+ Hits         1016     1022       +6     
+ Misses        402      396       -6
Impacted Files Coverage Δ
src/diagnostics.jl 79.66% <0%> (+3.38%) ⬆️
src/utils.jl 83.51% <0%> (+4.39%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 289b1e3...55ae7b1. Read the comment docs.

@glwagner
Copy link
Member

Is "verification" just a run script, or do we include analysis as well? Maybe need to have a folder for each verification case?

@ali-ramadhan
Copy link
Member Author

Thanks for the comments!

Is "verification" just a run script, or do we include analysis as well? Maybe need to have a folder for each verification case?

Yeah a folder for each might make sense. I'm envisioning that each verification test case is described in the documentation with enough figures/plots to convince the reader that Oceananigans is doing the right thing. There should be a simulation script (like the one in this PR) that allows the reader to reproduce the simulation, and probably one or more plotting scripts allowing them to recreate the plots.

@ali-ramadhan ali-ramadhan changed the title [WIP] Stratified Couette flow verification script [WIP] Stratified Couette flow verification Aug 30, 2019
@ali-ramadhan ali-ramadhan changed the title [WIP] Stratified Couette flow verification Stratified Couette flow verification Sep 6, 2019
@ali-ramadhan ali-ramadhan merged commit 211e18c into master Oct 14, 2019
@ali-ramadhan ali-ramadhan deleted the stratified-couette-flow branch October 14, 2019 22:06
arcavaliere pushed a commit to arcavaliere/Oceananigans.jl that referenced this pull request Nov 6, 2019
Stratified Couette flow verification

Former-commit-id: 211e18c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
numerics 🧮 So things don't blow up and boil the lobsters alive science 🌊 Sometimes addictive, sometimes allergenic testing 🧪 Tests get priority in case of emergency evacuation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

We should use CI to test that examples and verification tests run without errors Stratified plane Couette flow test
3 participants