Refactor vertical vorticity to return operation rather than Field #3340
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sounds good. Is this tested, do you know? |
navidcy
reviewed
Oct 14, 2023
Co-authored-by: Navid C. Constantinou <[email protected]>
|
I was thinking we'd find out via the tests |
navidcy
approved these changes
Nov 2, 2023
looks like it is |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following the newfound insight from implementing
seawater_density, I believe we always want to define these diagnostics to returnKernelFunctionOperationrather thanField. This PR also fixes the incorrect use of TitleCase.