Add radishes and seeds to the game

[juur]

Summary

Content "Add radishes and seeds"

Purpose of change

Introduce radishes as a fairly quick going vegetable, which would be helpful in a survival scenario.
I believe they are available in New England per https://gobotany.nativeplanttrust.org/species/raphanus/sativus/

Describe the solution

Added seeds and taproots using Wikipedia nutrient information. Updated some itemgroups and spawns to include, at a lower probability as I think (I'm not a native of the USA) they might be less common than other sorts of veg.

Describe alternatives you've considered

Testing

Spawn seeds and taproots. Check planting. Check recipes allow crafting using radishes.

Additional context

(I made the mistake of initially creating a branch from another branch, not master, but I think i rebase'd and tidied it up, but some unrelated stuff shows in the changelog)

[github-actions]

Spell checker encountered unrecognized words in the in-game text added in this pull request. See below for details.

Click to expand

• Crunchy red radish raproots

This alert is automatically generated. You can simply disregard if this is inaccurate, or (optionally) you can also add the new words to tools/spell_checker/dictionary.txt so they will not trigger an alert next time.

Hints for adding a new word to the dictionary

• If the word is normally in all lowercase, such as the noun word or the verb does, add it in its lower-case form; if the word is a proper noun, such as the surname George, add it in its initial-caps form; if the word is an acronym or has special letter case, such as the acronym CDDA or the unit mW, add it by preserving the case of all the letters. A word in the dictionary will also match its initial-caps form (if the word is in all lowercase) and all-uppercase form, so a word should be added to the dictionary in its normal letter case even if used in a different letter case in a sentence.
• For a word to be added to the dictionary, it should either be a real, properly-spelled modern American English word, a foreign loan word (including romanized foreign names), or a foreign or made-up word that is used consistently and commonly enough in the game. Intentional misspelling (including eye dialect) of a word should not be added unless it has become a common terminology in the game, because while someone may have a legitimate use for it, another person may spell it that way accidentally.

[moxian]

Consider adding the taproot to cooking_components.json where appropriate.

Separately, if you plant the radish seeds, you will then be able to harvest some taproots but not new seeds, making the seeds non-renewable. Do I understand this right? (this is just personal curiosity really)

[Karol1223]

You're also not adding them to the vegetable requirement group, so they'll be unusable in most crafting recipes. Add them there.

[juur]

Consider adding the taproot to cooking_components.json where appropriate.

Separately, if you plant the radish seeds, you will then be able to harvest some taproots but not new seeds, making the seeds non-renewable. Do I understand this right? (this is just personal curiosity really)

I think you have to leave them to grow longer to get useful seeds https://en.wikipedia.org/wiki/Radish#Seed_pod_varieties so maybe just put a couple in as a byproduct?

[moxian]

The seeds of radishes grow in siliques (widely referred to as "pods"), following flowering that happens when left to grow past their normal harvesting period.

Oh, so that's different from carrots, cabbages, turnips, onions and many other "similar" vegetables that are biennial (i.e. producing seeds on the second year). Yeah, having seeds as a byproduct is not entirely unreasonable here then!

(but it's probably also okay to leave them be nonrenewable given that other biennial plants are like that(?) already)

[Karol1223]

Not checking if the values are accurate to real life but the JSON at least seems fine now

[moxian]

Looks reasonable.
(There are no seed byproducts but that's fine with me. It would be a bigger project anyway)