Handle LLVMInstallDir not being set for llvm tools integration #71385
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
astyled
akrieger
force-pushed
the
macrosoft_whyyy
branch
from
147faf8 to
e2a35bd
Compare
github-actions
bot
added
json-styled
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
None
Purpose of change
Newer Visual Studio 2022 previews changed the build variables that are set when llvm tools are installed. There doesn't seem to be a guaranteed one for where one can find the preinstalled llvm tools anymore. This then breaks the thin archives integration.
Describe the solution
Use a fallback hardcoded path derived from $(VCInstallDir). There was at least one MSDN article that stated essentially the same.
Describe alternatives you've considered
Testing
Can build locally with thin archives again.
Additional context