add #216
Merged
add #216
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds end-to-end integration tests for the new OpenAI-compatible Clarifai endpoint, covering both synchronous and asynchronous flows.
- Introduces
API_KEYconstant sourced fromCLARIFAI_PAT - Adds helper functions (
_call_openai_model,_list_featured_models) for sync/async calls - Implements synchronous (
test_openai_compatible_endpoint_on_featured_models) and async (test_openai_compatible_endpoint_on_featured_models_async) integration tests
wemoveon2
force-pushed
the
add-tests
branch
2 times, most recently
from
fb4ed95 to
9338767
Compare
ackizilkale
approved these changes
Jun 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces significant enhancements to the testing framework for public models, focusing on integration with OpenAI-compatible endpoints and improving test reliability through retry mechanisms. It also adds new dependencies to support OpenAI API usage. Below is a summary of the most important changes.
Integration with OpenAI-compatible endpoints:
_call_openai_modeland_list_featured_modelsto test OpenAI-compatible models with retry logic for chat completions and image generation. These functions include error handling and parameter corrections for API compatibility. (tests/public_models/test_public_models_predicts.py, tests/public_models/test_public_models_predicts.pyR356-R500)test_openai_compatible_endpoint_on_featured_modelsandtest_openai_compatible_endpoint_on_featured_models_asyncto validate OpenAI-compatible endpoints on featured models, both synchronously and asynchronously. (tests/public_models/test_public_models_predicts.py, tests/public_models/test_public_models_predicts.pyR356-R500)Improvements to test reliability:
API_KEYandMAX_RETRY_ATTEMPTSfor managing authentication and retry logic in tests. (tests/public_models/test_public_models_predicts.py, tests/public_models/test_public_models_predicts.pyR42-R45)test_audio_predict_on_public_models_asyncfunction to support asynchronous testing. (tests/public_models/test_public_models_predicts.py, tests/public_models/test_public_models_predicts.pyL55)Dependency updates:
openai==1.86.0totests/requirements.txtto enable OpenAI API integration. (tests/requirements.txt, tests/requirements.txtR5)