Wireless SSID: data source, resource #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcparaf
force-pushed
the
wireless_ssid
branch
from
3cef640 to
8aaf184
Compare
danischm
requested changes
Sep 18, 2024
gen/definitions/wireless_ssid.yaml
Outdated
| @@ -0,0 +1,524 @@ | |||
| name: Wireless SSID | |||
| rest_endpoint: /networks/%v/wireless/ssids | |||
| data_source_name_query: true | |||
There was a problem hiding this comment.
I don't think this makes sense here, as we need the number for the path anyway.
There was a problem hiding this comment.
this could be implemented because there is a GET endpoint that lists all the SSIDs. but that would require the data source to have a different set of mandatory fields than the resource, so this would have to be manually implemented. removing for now, maybe we'll add this functionality later. i don't think this will that relevant in production anyways because all the SSIDs are explicitly fixed to their numbers (there is no POST endpoints, but rather a fixed number of SSID slots that could be edited with PUT)
added 2 commits
September 19, 2024 13:40
mcparaf
force-pushed
the
wireless_ssid
branch
from
8aaf184 to
3f1f76a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.