Skip to content

interfaces: add load-interval, link-status #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 27, 2024
Merged

interfaces: add load-interval, link-status #162

merged 6 commits into from
May 27, 2024

Conversation

jabielecki
Copy link
Collaborator

Closes #148

  • Add logging_event_link_status_enable and snmp_trap_link_status attributes to iosxe_interface_ethernet, iosxe_interface_port_channel, iosxe_interface_tunnel resources and data sources
  • Add load_interval attribute to iosxe_interface_ethernet, iosxe_interface_port_channel, iosxe_interface_tunnel, iosxe_interface_vlan resources and data sources

@jabielecki jabielecki requested a review from danischm May 24, 2024 14:40
- yang_name: load-interval
example: 30
- yang_name: Cisco-IOS-XE-snmp:snmp/trap/link-status
write_only: true
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this write_only? Is it not included in the GET response?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Originally I thought it was not worth the troubleshooting effort (a good few hours), but since you've raised a question I did spend some time on it. It seems that the culprit is source_template which overrides some (all?) settings.

Hence I propose to exclude it from tests, to avoid further confusion. I'd pushed a commit to that effect. Sounds good?

@danischm danischm merged commit 5135163 into main May 27, 2024
6 checks passed
@danischm danischm deleted the linkstatus branch May 27, 2024 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

resource iosxe_interface_ethernet additional commands
2 participants