Modified code in utils.go to ignore error when error text contains 'cannot be deleted.' and the error code is 1 (DCNE-380) #1354
Conversation
…ntains 'cannot be deleted.' and the error code is 1
shrsr
requested review from
akinross,
anvitha-jain,
gmicol,
lhercot,
sajagana and
samiib
as code owners
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
- Coverage 86.64% 84.75% -1.89%
==========================================
Files 133 163 +30
Lines 76831 96563 +19732
==========================================
+ Hits 66569 81842 +15273
- Misses 8198 12234 +4036
- Partials 2064 2487 +423 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
github-actions
bot
changed the title
| // Ignore errors of type "Cannot create object", "Cannot delete object", "Request in progress" and error text containing "can not be deleted." when the error code is 120 | ||
| if errCode == "103" || errCode == "107" || errCode == "202" || (errCode == "120" && strings.HasSuffix(errText, "can not be deleted.")) { | ||
| // Ignore errors of type "Cannot create object", "Cannot delete object", "Request in progress", error text containing "can not be deleted." when the error code is 120 and error text containing "cannot be deleted." when the error code is 1 | ||
| if errCode == "103" || errCode == "107" || errCode == "202" || (errCode == "120" && strings.HasSuffix(errText, "can not be deleted.")) || (errCode == "1" && strings.HasSuffix(errText, "cannot be deleted.")) { |
There was a problem hiding this comment.
Is a . dot always present at the end of an error message?
There was a problem hiding this comment.
I'm not sure. I think a few messages returned by the API have a dot but a few don't
There was a problem hiding this comment.
If so, shouldn't you remove the dot at the end since you're using the HasSuffix? it should then pass whenever or not the error message has a dot at the end
There was a problem hiding this comment.
@gmicol I was referring to all the error messages not just the one that has "cannot be deleted."
There was a problem hiding this comment.
Would using string.Contains(errText, "cannot be deleted") be possible to use instead? This way it will handle a full stop at the end or not. It may also handle the same error if additional message text is added to the error in future versions.
…estroy goes through successfully for undeletable objects
| // Ignore errors of type "Cannot create object", "Cannot delete object", "Request in progress" and error text containing "can not be deleted." when the error code is 120 | ||
| if errCode == "103" || errCode == "107" || errCode == "202" || (errCode == "120" && strings.HasSuffix(errText, "can not be deleted.")) { | ||
| // Ignore errors of type "Cannot create object", "Cannot delete object", "Request in progress", error text containing "can not be deleted." when the error code is 120 and error text containing "cannot be deleted." when the error code is 1 | ||
| if errCode == "103" || errCode == "107" || errCode == "202" || (errCode == "120" && strings.HasSuffix(errText, "can not be deleted.")) || (errCode == "1" && strings.HasSuffix(errText, "cannot be deleted.")) { |
There was a problem hiding this comment.
If so, shouldn't you remove the dot at the end since you're using the HasSuffix? it should then pass whenever or not the error message has a dot at the end
| // Ignore errors of type "Cannot create object", "Cannot delete object", "Request in progress" and error text containing "can not be deleted." when the error code is 120 | ||
| if errCode == "103" || errCode == "107" || errCode == "202" || (errCode == "120" && strings.HasSuffix(errText, "can not be deleted.")) { | ||
| // Ignore errors of type "Cannot create object", "Cannot delete object", "Request in progress", error text containing "can not be deleted." when the error code is 120 and error text containing "cannot be deleted." when the error code is 1 | ||
| if errCode == "103" || errCode == "107" || errCode == "202" || (errCode == "120" && strings.HasSuffix(errText, "can not be deleted.")) || (errCode == "1" && strings.HasSuffix(errText, "cannot be deleted.")) { |
There was a problem hiding this comment.
Would using string.Contains(errText, "cannot be deleted") be possible to use instead? This way it will handle a full stop at the end or not. It may also handle the same error if additional message text is added to the error in future versions.
No description provided.