Generator redesign read meta for resource name to class struct (DCNE-345) #1350
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akinross
requested review from
anvitha-jain,
gmicol,
lhercot,
sajagana,
samiib and
shrsr
as code owners
akinross
changed the title
akinross
force-pushed
the
generator_redesign_read_meta_to_class_struct
branch
from
aba6ba9 to
9012df2
Compare
shrsr
requested changes
May 14, 2025
gen/utils/data/class.go
Outdated
| func (c *Class) setResourceName() error { | ||
| genLogger.Debug(fmt.Sprintf("Setting resource name for class '%s'.", c.ClassName)) | ||
|
|
||
| // TODO: add logic to override the resource name from an definition file. |
There was a problem hiding this comment.
Not important but..
->
// TODO: add logic to override the resource name from a definition file.
There was a problem hiding this comment.
assuming the change was an to a, changed this now
lhercot
requested changes
May 21, 2025
lhercot
requested changes
May 22, 2025
Comment on lines
+235
to
+239
| if label, ok := c.MetaFileContent["label"]; ok && label != "" { | ||
| c.ResourceName = utils.Underscore(label.(string)) | ||
| } else { | ||
| return fmt.Errorf("failed to set resource name for class '%s': label not found", c.ClassName) | ||
| } |
There was a problem hiding this comment.
This also does not account for relational classes right where we need to add relation_ right?
There was a problem hiding this comment.
ok will include logic for this
Comment on lines
+70
to
+75
| for _, test := range tests { | ||
| genLogger.Info(fmt.Sprintf("Executing: %s' with input '%s' and expected output '%s'", t.Name(), test["input"], test["expected"])) | ||
| result, err := Plural(test["input"]) | ||
| assert.NoError(t, err, fmt.Sprintf("Expected no error, but got '%s'", err)) | ||
| assert.Equal(t, test["expected"], result, fmt.Sprintf("Expected '%s', but got '%s'", test["expected"], result)) | ||
| } |
There was a problem hiding this comment.
This seems to be repeated in some fashion quite a bit. Should this be a function that accept a series of attribute including the tested function?
There was a problem hiding this comment.
will have a look at creating functions for all the repeating tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes DCNE-345