Skip to content

[semver:minor] Basic Heroku container support. #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jul 22, 2020
Merged

[semver:minor] Basic Heroku container support. #9

merged 4 commits into from
Jul 22, 2020

Conversation

gmemstr
Copy link
Contributor

@gmemstr gmemstr commented Jul 16, 2020

No description provided.

@gmemstr gmemstr linked an issue Jul 16, 2020 that may be closed by this pull request
Heroku Docker Container Support #6
Closed
@gmemstr gmemstr force-pushed the 6-container-support branch from 3ac31ad to 2184247 Compare July 16, 2020 13:08
@gmemstr gmemstr force-pushed the 6-container-support branch from e6c30b5 to be46b75 Compare July 16, 2020 13:16
@gmemstr gmemstr force-pushed the 6-container-support branch from be46b75 to 41e0b09 Compare July 16, 2020 13:20
@gmemstr gmemstr marked this pull request as ready for review July 16, 2020 14:34
@gmemstr gmemstr changed the title Basic Heroku container support. [semver:minor] Basic Heroku container support. Jul 16, 2020
@dsayling dsayling self-requested a review July 16, 2020 15:53
@dsayling
Copy link
Contributor

I still dont know how just approve when I comment. 😬 Where's bitbucket again...?

@dsayling dsayling removed their request for review July 16, 2020 16:09
dsayling
dsayling approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@dsayling dsayling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whew - so hard 🤣

@gmemstr gmemstr merged commit dd9b245 into master Jul 22, 2020
@gmemstr gmemstr deleted the 6-container-support branch July 22, 2020 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsayling dsayling dsayling approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Heroku Docker Container Support
2 participants
@gmemstr @dsayling