Skip to content

[semver:minor] Review support #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Sep 1, 2021
Merged

[semver:minor] Review support #36

merged 14 commits into from
Sep 1, 2021

Conversation

gmemstr
Copy link
Contributor

@gmemstr gmemstr commented Aug 18, 2021

See #24

Gabriel Simmer added 2 commits August 18, 2021 10:00
Add initial create-review script.
@gmemstr
Copy link
Contributor Author

gmemstr commented Aug 18, 2021

Currently missing is how to best handle messages returned from Heroku and CircleCI's APIs. jq is an option.

Copy link
Contributor

@KyleTryon KyleTryon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My only comment is I would imagine the pipeline id should be a secret.

@gmemstr gmemstr merged commit 7e3870d into master Sep 1, 2021
@gmemstr gmemstr deleted the reviews branch September 1, 2021 10:14
@4eRTuk
Copy link

4eRTuk commented Aug 25, 2022

How to use this feature? I try to setup job from example file, but the following error occurs in CircleCI Dashboard:

Error calling workflow: 'sample'Error calling job: 'deploy'Cannot find a definition for command named heroku/create-review

@KyleTryon
Copy link
Contributor

How to use this feature? I try to setup job from example file, but the following error occurs in CircleCI Dashboard:

Error calling workflow: 'sample'Error calling job: 'deploy'Cannot find a definition for command named heroku/create-review

What interesting timing. I just noticed this as well. I am taking the week to rebuild this orb and resolve issues. We'll have this cleaned up soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants