Skip to content

[semver:patch] Push to main instead of master #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2020

Conversation

levent
Copy link
Contributor

@levent levent commented Oct 25, 2020

No description provided.

@gmemstr
Copy link
Contributor

gmemstr commented Oct 26, 2020

@levent I think a better approach would be to create a new parameter that defaults to one or the other - I don't see this as a priority though, since master branch will continue to work. That said, there doesn't seem to be any difference between the two, so this is a relatively low impact change.

@gmemstr gmemstr changed the title Push to main instead of master [semver:patch] Push to main instead of master Oct 26, 2020
@gmemstr
Copy link
Contributor

gmemstr commented Oct 26, 2020

Continuing this discussion internally, but my current line of thinking is that this would be future proofing to some degree - I don't see heroku dropping master anytime soon, but longer term it's a possibility.

@gmemstr gmemstr merged commit 4b7058a into CircleCI-Public:master Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants