Skip to content

push-docker-image does not work either as a job or as a command #18

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
markku63 opened this issue Aug 27, 2020 · 10 comments
Closed

push-docker-image does not work either as a job or as a command #18

markku63 opened this issue Aug 27, 2020 · 10 comments
Labels
bug Something isn't working

Comments

@markku63
Copy link

Orb Version
1.2.2

Describe the bug
First, I tried to use the heroku/push-docker-image job, and it failed in the "Login to Heroku Docker image registry" step with error:

Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
 ▸    Login failed with: 1

Some Googling revealed that this is caused by a missing setup_remote_docker step, so I tried my own job with that step included before the heroku/push-docker-image command. This time it failed at "Push Docker image to Heroku" with:

#!/bin/bash -eo pipefail
heroku container:push -a $HEROKU_APP_NAME \

web

 ▸    Error: Requires either
 ▸    --recursive or one or
 ▸    more process types


Exited with code exit status 1

CircleCI received exit code 1

There appears to be an extra linefeed (or a missing backslash) in the command.

To Reproduce
Set up a CircleCI project following my public GitHub repo at https://github.com/markku63/mooc-wepa-20-projekti
Define the HEROKU_APP_NAME and HEROKU_API_KEY environment variables.

Expected behavior
The project builds and deploys to Heroku.

Additional context

@markku63 markku63 added the bug Something isn't working label Aug 27, 2020
@n2taylor
Copy link

I've encountered this issue with the backslash too, it's definitely missing. As a workaround/hack you can pass the desired CLI args inside HEROKU_APP_NAME

@eerison
Copy link

eerison commented Nov 22, 2020

the same here 😕
any one working on this issue?

remmelt added a commit to remmelt/heroku-orb that referenced this issue Jan 29, 2021
Process types were not picked up by the push-docker-image command, due
to a missing back slash. This should fix that.
@sahilrajput03
Copy link

sahilrajput03 commented Feb 1, 2021

Is this added to latest orb image yet.? @eerison

@eerison
Copy link

eerison commented Feb 1, 2021

Hi @sahilrajput03 I'll test the latest version and I'll post here the result
Thanks :)

dsayling pushed a commit that referenced this issue Feb 1, 2021
Process types were not picked up by the push-docker-image command, due
to a missing back slash. This should fix that.
@dsayling
Copy link
Contributor

dsayling commented Feb 1, 2021

Fix is in version 1.2.5+ of the orb.

@dsayling dsayling closed this as completed Feb 1, 2021
@sahilrajput03
Copy link

Thanks a lot!

@eerison
Copy link

eerison commented Feb 6, 2021

I guess it does't resolve this issue
PR: https://github.com/eerison/myprofile/pull/310/files
pipeline: https://app.circleci.com/pipelines/github/eerison/myprofile/518/workflows/03dd35c0-3f2d-4e95-828e-e5ddc538bbe8/jobs/1041

#!/bin/bash -eo pipefail
heroku container:login
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
 ▸    Login failed with: 1


Exited with code exit status 1
CircleCI received exit code 1

the problem is authentication is not working ....

But why ? 😕

@sahilrajput03
Copy link

This problem can be easily resolved by using this knowledge!!.

IMG_20210207_123540.jpg

@sahilrajput03
Copy link

I guess it does't resolve this issue
PR: https://github.com/eerison/myprofile/pull/310/files
pipeline: https://app.circleci.com/pipelines/github/eerison/myprofile/518/workflows/03dd35c0-3f2d-4e95-828e-e5ddc538bbe8/jobs/1041

#!/bin/bash -eo pipefail
heroku container:login
Cannot connect to the Docker daemon at unix:///var/run/docker.sock. Is the docker daemon running?
 ▸    Login failed with: 1


Exited with code exit status 1
CircleCI received exit code 1

the problem is authentication is not working ....

But why ? 😕
The error clearly says cannot connect to docker daemon, its not at all related to authentication, the problem is docker isn't installed, you install docker using setup-remote-docker instruction in ur config.yml file as heroku underneath uses docker.

@sahilrajput03
Copy link

sahilrajput03 commented Feb 7, 2021

Above photograph is from this url: https://circleci.com/docs/2.0/building-docker-images/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

5 participants