-
-
Notifications
You must be signed in to change notification settings - Fork 376
Add save all transactions functionality #1214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
4eabd52
Add save-to-file functionality for transactions
irakliy01 512d116
Add test for FileSaver.saveFile method
irakliy01 4e650fb
Update CHANGELOG.md
irakliy01 d1fdbfa
Remove unnecessary private saveToFile method from FileSaver
irakliy01 9ae5c2f
Add "empty content test" for FileSaverTest
irakliy01 fb26daa
Document FileSaver class
irakliy01 13220ef
Small refactor
irakliy01 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
41 changes: 41 additions & 0 deletions
41
library/src/main/kotlin/com/chuckerteam/chucker/internal/support/FileSaver.kt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,41 @@ | ||
package com.chuckerteam.chucker.internal.support | ||
|
||
import android.content.ContentResolver | ||
import android.net.Uri | ||
import kotlinx.coroutines.Dispatchers | ||
import kotlinx.coroutines.withContext | ||
import okio.Source | ||
import okio.buffer | ||
import okio.sink | ||
|
||
/** | ||
* Utility class to save a file from a [Source] to a [Uri]. | ||
*/ | ||
public object FileSaver { | ||
/** | ||
* Saves the data from the [source] to the file at the [uri] using the [contentResolver]. | ||
* | ||
* @param source The source of the data to save. | ||
* @param uri The URI of the file to save the data to. | ||
* @param contentResolver The content resolver to use to save the data. | ||
* @return `true` if the data was saved successfully, `false` otherwise. | ||
*/ | ||
public suspend fun saveFile( | ||
source: Source, | ||
uri: Uri, | ||
contentResolver: ContentResolver, | ||
): Boolean = | ||
withContext(Dispatchers.IO) { | ||
runCatching { | ||
contentResolver.openOutputStream(uri)?.use { outputStream -> | ||
outputStream.sink().buffer().use { sink -> | ||
sink.writeAll(source) | ||
} | ||
} | ||
}.onFailure { | ||
Logger.error("Failed to save data to a file", it) | ||
return@withContext false | ||
} | ||
return@withContext true | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is unneceesary?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no action on dismiss (old actions also set this listener as null)