Escape quotes in curl share

CHANGELOG.md

@@ -7,6 +7,7 @@ Please add your entries according to this format.
 
 * Fixed activity still asking for notification permission when notifications are disabled [#1165]
 * Fixed Gson issue, when using Chucker with ProGuard [#1183]
+* Fixed share of curl when header values contain quotes [#1211]
 
 ### Added
 

library/src/main/kotlin/com/chuckerteam/chucker/internal/support/TransactionCurlCommandSharable.kt

@@ -19,7 +19,8 @@ internal class TransactionCurlCommandSharable(
                 if (isCompressed(header)) {
                     compressed = true
                 }
-                writeUtf8(" -H \"${header.name}: ${header.value}\"")
+                val headerValue = escapeHeaderValue(header.value)
+                writeUtf8(" -H \"${header.name}: ${headerValue}\"")
             }
 
             val requestBody = transaction.requestBody
@@ -37,4 +38,9 @@ internal class TransactionCurlCommandSharable(
                 "br".contains(header.value, ignoreCase = true)
         )
     }
+
+    private fun escapeHeaderValue(value: String): String {
+        // escape double quotes from header value to prevent getting an invalid curl
+        return value.replace("\"", "\\\"")
+    }
 }

library/src/test/kotlin/com/chuckerteam/chucker/internal/support/TransactionCurlCommandSharableTest.kt

@@ -53,6 +53,32 @@ internal class TransactionCurlCommandSharableTest {
         }
     }
 
+    @Test
+    fun `create cURL command with quote value in header`() {
+        val headers =
+            listOf(
+                HttpHeader("X-JSON-Object", "{\"name\": \"value\"}"),
+                HttpHeader("Etag", "W/\"0815\""),
+            )
+        val convertedHeaders = JsonConverter.instance.toJson(headers)
+
+        requestMethods.forEach { method ->
+            val transaction =
+                TestTransactionFactory.createTransaction(method).apply {
+                    requestHeaders = convertedHeaders
+                }
+            val sharableTransaction = TransactionCurlCommandSharable(transaction)
+            val expectedCurlCommand =
+                """
+                curl -X $method -H "X-JSON-Object: {\"name\": \"value\"}" -H "Etag: W/\"0815\"" http://localhost/getUsers
+                """.trimIndent()
+
+            val sharedContent = sharableTransaction.toSharableUtf8Content(context)
+
+            assertThat(sharedContent).isEqualTo(expectedCurlCommand)
+        }
+    }
+
     @Test
     fun `create cURL command with request bodies for PUT and POST methods`() {
         requestMethods.filter { it in listOf("POST", "PUT") }.forEach { method ->
@@ -85,7 +111,8 @@ internal class TransactionCurlCommandSharableTest {
 
             val sharedContent = sharableTransaction.toSharableUtf8Content(context)
 
-            val expected = "curl -X $method -H \"Accept-Encoding: gzip\" --compressed http://localhost/getUsers"
+            val expected =
+                "curl -X $method -H \"Accept-Encoding: gzip\" --compressed http://localhost/getUsers"
 
             assertThat(sharedContent).isEqualTo(expected)
         }