Skip to content

add KMP search algorithm (gated by build flag) #1277

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 14, 2025

Conversation

midzer
Copy link
Contributor

@midzer midzer commented Feb 23, 2025

Description

KMP search algorithm by feature discussion in #880

Should fix #1229

Types of changes

  • Chore (tooling change or documentation change)
  • Refactor (non-breaking change which maintains existing functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project.
  • I have added new tests for the bug I fixed/the new feature I added.
  • I have modified existing tests for the bug I fixed/the new feature I added.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@midzer
Copy link
Contributor Author

midzer commented Feb 23, 2025

Note: this PR has not been tested yet, as npm watch environment threw other, unrelated errors in the browser dev console. Also, tests and linter has not been run.

@Xon Xon added change request changes required Pull request requires changes before it can be merged labels Feb 26, 2025
@Xon Xon self-requested a review February 26, 2025 12:58
@Xon
Copy link
Collaborator

Xon commented Feb 26, 2025

@midzer you can ignore those e2e test failures, but the unit tests probably need a bit more work and eslint run on the code to match the rest of the code base.

@Xon Xon added feature Pull request that adds new functionality and removed change request labels Feb 26, 2025
@Xon Xon removed the changes required Pull request requires changes before it can be merged label Feb 26, 2025
@Xon Xon changed the base branch from main to v12 February 26, 2025 19:27
@Xon
Copy link
Collaborator

Xon commented Feb 26, 2025

I've setup a new v12 branch for new feature work, once that is done it can get merged into main

@Xon
Copy link
Collaborator

Xon commented Mar 14, 2025

I've fixed the issue with the search flags, and will merge that into the next version update (v11.1.0 as this can be done without breaking backwards compatibility)

Xon
Xon previously approved these changes Mar 14, 2025
@Xon Xon changed the base branch from v12 to main March 14, 2025 01:07
@Xon Xon dismissed their stale review March 14, 2025 01:07

The base branch was changed.

@Xon Xon changed the title add SearchByKMP add KMP search algorithm (gated by build flag) Mar 14, 2025
@Xon Xon merged commit bf2cfb9 into Choices-js:main Mar 14, 2025
11 checks passed
@midzer midzer deleted the addSearchByKMP branch March 14, 2025 06:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature Pull request that adds new functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Require all words to be found / AND search
2 participants