Skip to content

Update snapshots #8308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
May 23, 2025
Merged

Update snapshots #8308

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
6df1726
[Fusion] Add support for result from different subgraph on interfaces
Enterprize1 May 19, 2025
f8a1b65
Add Fusion interface tests
tobias-tengler May 6, 2025
76a6234
Check in updated artifacts
tobias-tengler May 19, 2025
ce3e74e
Fix snapshots
tobias-tengler May 23, 2025
cefbb66
fix asssert
tobias-tengler May 23, 2025
46256d4
Merge branch 'fusion-15-interface-fix' into fix_fusion_on_interfaces
PascalSenn May 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions src/HotChocolate/Fusion/src/Core/Planning/Pipeline/ExecutionStepDiscoveryMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,11 +447,11 @@ private void CollectNestedSelections(
}

private static void TryEnqueueBacklogItem(
Queue<BacklogItem> backlog,
ISelection parentSelection,
SelectionPath? selectionSetPath,
ObjectTypeMetadata declaringType,
List<ISelection> leftovers,
Queue<BacklogItem> backlog,
ISelection parentSelection,
SelectionPath? selectionSetPath,
ObjectTypeMetadata declaringType,
List<ISelection> leftovers,
bool preferBatching)
{
foreach (var item in backlog)
Expand Down
2 changes: 1 addition & 1 deletion src/HotChocolate/Fusion/test/Core.Tests/UnionTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -479,7 +479,7 @@ ... on Item3 {
CollectSnapshotData(snapshot, request, result);
await snapshot.MatchMarkdownAsync();
// Ideally it would just be one request, but that's for another day...
Assert.Equal(3, subgraphB.NumberOfReceivedRequests);
Assert.Equal(2 , subgraphB.NumberOfReceivedRequests);
}

[Fact]
Expand Down
24 changes: 5 additions & 19 deletions ...Interface_And_Concrete_Type_On_Node_Field_Interface_Selection_Has_Dependency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,18 +7,18 @@
"data": {
"node": {
"__typename": "Item2",
"id": "something",
"id": "SXRlbTI6MQ==",
"products": [
{
"id": "1",
"id": "2",
"name": "string"
},
{
"id": "2",
"id": "3",
"name": "string"
},
{
"id": "3",
"id": "4",
"name": "string"
}
],
Expand Down Expand Up @@ -55,7 +55,7 @@ query testQuery($id: ID!) {
## QueryPlan Hash

```text
7F627F0C88E6A2C3CDB2AAE846ED84105A66D357
D7ECED31E24122116A43B641BB4FE1FFDC849F00
```

## QueryPlan
Expand Down Expand Up @@ -152,20 +152,6 @@ query testQuery($id: ID!) {
"variable": "__fusion_exports__2"
}
]
},
{
"type": "ResolveByKeyBatch",
"subgraph": "Subgraph_2",
"document": "query testQuery_6($__fusion_exports__1: [ID!]!) { nodes(ids: $__fusion_exports__1) { ... on Product { name __fusion_exports__1: id } } }",
"selectionSetId": 4,
"path": [
"nodes"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
}
]
},
Expand Down
39 changes: 10 additions & 29 deletions ...ions_On_Interface_Field_And_Concrete_Type_Interface_Selection_Has_Dependency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ query testQuery {
## QueryPlan Hash

```text
2E441B48CD5764FF5C99D83377ED4452DA4968AF
5722F5134A038091DDEBF004D5733DF1141AD163
```

## QueryPlan
Expand Down Expand Up @@ -65,35 +65,16 @@ query testQuery {
]
},
{
"type": "Parallel",
"nodes": [
{
"type": "Resolve",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: ID!) { authorById(id: $__fusion_exports__1) { displayName } }",
"selectionSetId": 3,
"path": [
"authorById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
},
"type": "Resolve",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: ID!) { authorById(id: $__fusion_exports__1) { displayName } }",
"selectionSetId": 3,
"path": [
"authorById"
],
"requires": [
{
"type": "Resolve",
"subgraph": "Subgraph_2",
"document": "query testQuery_3($__fusion_exports__1: ID!) { authorById(id: $__fusion_exports__1) { displayName } }",
"selectionSetId": 3,
"path": [
"authorById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
"variable": "__fusion_exports__1"
}
]
},
Expand Down
39 changes: 10 additions & 29 deletions ...erfaceTests.Selections_On_Interface_Field_Interface_Selection_Has_Dependency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ query testQuery {
## QueryPlan Hash

```text
D772126D1EEF02DAC266CB5A057F564060D55FD9
E1E94C2534B99BC1CF6E9A80F111DBAE1A83C80C
```

## QueryPlan
Expand Down Expand Up @@ -61,35 +61,16 @@ D772126D1EEF02DAC266CB5A057F564060D55FD9
]
},
{
"type": "Parallel",
"nodes": [
{
"type": "Resolve",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: ID!) { authorById(id: $__fusion_exports__1) { displayName } }",
"selectionSetId": 3,
"path": [
"authorById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
},
"type": "Resolve",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: ID!) { authorById(id: $__fusion_exports__1) { displayName } }",
"selectionSetId": 3,
"path": [
"authorById"
],
"requires": [
{
"type": "Resolve",
"subgraph": "Subgraph_2",
"document": "query testQuery_3($__fusion_exports__1: ID!) { authorById(id: $__fusion_exports__1) { displayName } }",
"selectionSetId": 3,
"path": [
"authorById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
"variable": "__fusion_exports__1"
}
]
},
Expand Down
43 changes: 12 additions & 31 deletions ...On_Interface_List_Field_And_Concrete_Type_Interface_Selection_Has_Dependency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
"authorables": [
{
"author": {
"id": "1",
"id": "3",
"displayName": "string"
},
"title": "string"
Expand All @@ -22,7 +22,7 @@
},
{
"author": {
"id": "3",
"id": "1",
"displayName": "string"
},
"title": "string"
Expand Down Expand Up @@ -51,7 +51,7 @@ query testQuery {
## QueryPlan Hash

```text
FE8F78F204FBA396327AB3E2F3F44563E61F9216
5B15C51B0C560FDA557AEC4D18F7435E73169D29
```

## QueryPlan
Expand Down Expand Up @@ -81,35 +81,16 @@ FE8F78F204FBA396327AB3E2F3F44563E61F9216
]
},
{
"type": "Parallel",
"nodes": [
{
"type": "ResolveByKeyBatch",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: [ID!]!) { authorsById(ids: $__fusion_exports__1) { displayName __fusion_exports__1: id } }",
"selectionSetId": 3,
"path": [
"authorsById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
},
"type": "ResolveByKeyBatch",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: [ID!]!) { authorsById(ids: $__fusion_exports__1) { displayName __fusion_exports__1: id } }",
"selectionSetId": 3,
"path": [
"authorsById"
],
"requires": [
{
"type": "ResolveByKeyBatch",
"subgraph": "Subgraph_2",
"document": "query testQuery_3($__fusion_exports__1: [ID!]!) { authorsById(ids: $__fusion_exports__1) { displayName __fusion_exports__1: id } }",
"selectionSetId": 3,
"path": [
"authorsById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
"variable": "__fusion_exports__1"
}
]
},
Expand Down
49 changes: 15 additions & 34 deletions ...eTests.Selections_On_Interface_List_Field_Interface_Selection_Has_Dependency.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,21 +8,21 @@
"authorables": [
{
"author": {
"id": "1",
"id": "3",
"displayName": "string"
},
}
},
{
"author": {
"id": "1",
"id": "2",
"displayName": "string"
},
}
},
{
"author": {
"id": "1",
"displayName": "string"
},
}
}
]
}
Expand All @@ -45,7 +45,7 @@ query testQuery {
## QueryPlan Hash

```text
F4039AE7E0301C2C3A6B64A727FD0898C6ED5C3E
0308D4AF6E31B24ABE6DE11C06361B922371BB60
```

## QueryPlan
Expand Down Expand Up @@ -75,35 +75,16 @@ F4039AE7E0301C2C3A6B64A727FD0898C6ED5C3E
]
},
{
"type": "Parallel",
"nodes": [
"type": "ResolveByKeyBatch",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: [ID!]!) { authorsById(ids: $__fusion_exports__1) { displayName __fusion_exports__1: id } }",
"selectionSetId": 3,
"path": [
"authorsById"
],
"requires": [
{
"type": "ResolveByKeyBatch",
"subgraph": "Subgraph_2",
"document": "query testQuery_2($__fusion_exports__1: [ID!]!) { authorsById(ids: $__fusion_exports__1) { displayName __fusion_exports__1: id } }",
"selectionSetId": 3,
"path": [
"authorsById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
},
{
"type": "ResolveByKeyBatch",
"subgraph": "Subgraph_2",
"document": "query testQuery_3($__fusion_exports__1: [ID!]!) { authorsById(ids: $__fusion_exports__1) { displayName __fusion_exports__1: id } }",
"selectionSetId": 3,
"path": [
"authorsById"
],
"requires": [
{
"variable": "__fusion_exports__1"
}
]
"variable": "__fusion_exports__1"
}
]
},
Expand Down
Loading